Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling ongoing file uploads #37

Open
RichardBruskiewich opened this issue May 28, 2021 · 2 comments
Open

Cancelling ongoing file uploads #37

RichardBruskiewich opened this issue May 28, 2021 · 2 comments
Assignees
Labels
Post-September Relay Changes Post September 2021 Relay bug fixes / feature addition

Comments

@RichardBruskiewich
Copy link
Collaborator

Is there a use case and is it feasible to allow data submitters to gracefully cancel an upload process? What happens if the "Done Upload" is not yet pressed and the user leaves the upload screen.

@RichardBruskiewich
Copy link
Collaborator Author

Our current design may actually keep an upload "going" after a browser window is closed (bug or feature?). There needs to be a more graceful, user-controlled mechanism. Is there a browser-mediated way of intercepting a "window closure event" within which a user may be prompted to "cancel" their upload (or just use it to cancel the upload).

@RichardBruskiewich
Copy link
Collaborator Author

Mechanism implemented!

However, we need to check if MPU uploads are cleanly cancelled (since an embedded exception is thrown inside the s3_client.upload_fileobj() call.

@RichardBruskiewich RichardBruskiewich added Post-September Relay Changes Post September 2021 Relay bug fixes / feature addition and removed September 2021 Relay September 2021 Relay bug fix / feature addition labels Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Post-September Relay Changes Post September 2021 Relay bug fixes / feature addition
Projects
None yet
Development

No branches or pull requests

2 participants