Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alternative vpc configuration for workflows api #145

Merged
merged 2 commits into from
May 1, 2024

Conversation

botanical
Copy link
Member

@botanical botanical commented Apr 30, 2024

Summary: Summary of changes

Addresses VEDA-146: Develop amazing new feature

Changes

  • Updated main.tf to create a security group for the workflows API lambda
  • Updated main.tf to set up VPC for the workflows API lambda
  • Updated the necessary variables, etc, files and tested with a local deployment

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@botanical
Copy link
Member Author

I suppose this is technically accurate but maybe we should add guidance on what subnet IDs should be set since the VPC ID is inferred from those values. 🤔

@botanical botanical merged commit cfb7cc1 into dev May 1, 2024
6 checks passed
@botanical botanical deleted the jt/add-networking-config-for-workflows branch May 1, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants