Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple numeric argument types (int, float, and unsigned) #12

Open
camargo opened this issue Mar 16, 2023 · 1 comment
Open

Add multiple numeric argument types (int, float, and unsigned) #12

camargo opened this issue Mar 16, 2023 · 1 comment
Assignees
Labels
breaking change A change that will require updating downstream code feature A new feature or feature request

Comments

@camargo
Copy link
Member

camargo commented Mar 16, 2023

Currently numeric arguments only support the number type. This task is to replace number with more numeric argument types in accordance with the AMPCS command dictionary argument types. The AMPCS types are:

  • int
  • float
  • unsigned
  • numeric (this is deprecated according to AMPCS so we probably should not include it)
@camargo camargo added breaking change A change that will require updating downstream code feature A new feature or feature request labels Mar 16, 2023
@camargo camargo added this to Aerie Mar 16, 2023
@github-project-automation github-project-automation bot moved this to Todo in Aerie Mar 16, 2023
@dyst5422
Copy link

I recommend us using full specification on these - U8, U16, I8, I16 etc etc.

This is also going to require custom validation in our typechecker/monaco instance, similar to how we had our time strings validated (not sure if that ever got in or if we are still somewhat blocked on the change in Monaco we've looked at previously).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change that will require updating downstream code feature A new feature or feature request
Projects
Status: Todo
Development

No branches or pull requests

3 participants