Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching modes and time systems doesn't assert the default bounds of the new time system #253

Open
mudinthewater opened this issue Dec 16, 2024 · 0 comments
Labels
defect every defect must have an accompanying criticality, or `crit-`

Comments

@mudinthewater
Copy link
Contributor

Issue mentioned as part of: #252

Describe the defect

When switching between modes or time systems, unexpected time ranges are applied to the incoming mode. These range from benign (Switching from realtime to recorded asserts the same window as the realtime window, for example) to absurd - switching from sclk to scet can result in a time in 1969.

Expected behavior

I am torn on the realtime->recorded behavior. In some respects, switching from realtime to recorded should show you exactly what you were just on. But a more natural workflow would be that switching from realtime to recorded either:

  1. shows you the default recorded bounds
  2. shows you the last range that the fixed timespan had

I'm somewhat not convinced that my users will want to switch to recorded to see the exact same range they just left in realtime mode, but this one is subjective.

The bigger problem is that the default bounds of time systems don't seem to be applied when switching from time system to time system. So switching ERT to SCET causes issues or scet to sclk, etc etc. I think when switching time systems the most natural thing would be that the new time system has its default bounds asserted. Thoughts @davetsay or @jvigliotta?

Steps To Reproduce
1.

Additional context

@mudinthewater mudinthewater added the defect every defect must have an accompanying criticality, or `crit-` label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect every defect must have an accompanying criticality, or `crit-`
Projects
None yet
Development

No branches or pull requests

1 participant