Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Links] Session information in links should be respected #233

Open
jvigliotta opened this issue Nov 13, 2024 · 1 comment
Open

[Links] Session information in links should be respected #233

jvigliotta opened this issue Nov 13, 2024 · 1 comment

Comments

@jvigliotta
Copy link
Collaborator

Describe the defect

Link session information is being ignored.

Expected behavior

Links with session information should be filtered by that session when visited.

Steps To Reproduce

  1. Filter by a session (we'll call it session A)
  2. Then create a link
  3. Then in the same browser filter a different set of sessions (we'll say, B, C, D)
  4. Open a new tab and paste the link created in step 2
  5. The new tab is filtered by sessions B, C, and D from step 3, it should be filtered by session A, which is the session when the link was created

Additional context

@jvigliotta jvigliotta added defect every defect must have an accompanying criticality, or `crit-` crit-2 regression labels Nov 13, 2024
@mudinthewater
Copy link
Contributor

Cases for you to consider:

Copying a: Link that has session filters on
to a: OMM that has session filtering enabled and currently active
Expectation: Whatever session filtering in the link is prioritized over the browser cache session filtering.

Copying: A link that has session filtering off:
To a: OMM that has session filtering enabled and currently active
Expectation: idk I'd have to test previous behavior to even figure out what this would do. Maybe respect the lack of filtering in the link? Maybe respect the current filtering in the instance?

Copying: A link that has session filtering off
To a: OMM that has session filtering enabled, but not currently selected
Expectation: No session filtering. (Makes sense they both agree)

Copying: A link that has session filtering on
to a: OMM with session filtering disabled
Expectation: OMM will strip the filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants