Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Hinting for Immediate Commands #932

Closed
cartermak opened this issue May 11, 2023 · 2 comments
Closed

No Hinting for Immediate Commands #932

cartermak opened this issue May 11, 2023 · 2 comments
Labels
bug Something isn't working clipper Requests from the Europa Clipper project sequencing Anything related to the sequencing domain

Comments

@cartermak
Copy link
Member

Checked for duplicates

Yes - I've already checked

Is this a regression?

No - This is a new bug

Version

1.6.0

Describe the bug

Argument hinting doesn't work on immediate commands. This screenshot shows the hinting/autofill options after using Ctrl + Space when filling out immediate command arguments; starting to type the argument name doesn't filter down to the allowable value (echo_string, here), either.

image

Reproduction

  • Create/edit a sequence with an immediate_commands list defined
  • Write the stem of an immediate command that has arguments and type the opening parenthesis and curly brace
  • Use the Ctrl + Space shortcut
  • Observe that the type hinting (which works for commands in steps) doesn't work

Logs

No response

System Info

Firefox 102.11.0esr on MacOS 13.3.1 (a)

Severity

Minor

@cartermak cartermak added bug Something isn't working sequencing Anything related to the sequencing domain clipper Requests from the Europa Clipper project labels May 11, 2023
@github-project-automation github-project-automation bot moved this to Todo in Aerie May 11, 2023
@camargo camargo removed this from Aerie May 11, 2023
@camargo
Copy link
Member

camargo commented May 11, 2023

This is a limitation noted in #827. We could not support typing for these commands since the Seq JSON spec does not specify a type.

This should be obviated by #877 when we update the Seq JSON spec to use a realtime_commands property instead of immediate and hardware. Closing this, please track #877. Will note this ticket there.

@cartermak
Copy link
Member Author

Ah -- thanks @camargo. I'll track that ticket/the SeqJSON schema change for this functionality.

@dandelany dandelany added this to Aerie Jan 22, 2024
@github-project-automation github-project-automation bot moved this to Todo in Aerie Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clipper Requests from the Europa Clipper project sequencing Anything related to the sequencing domain
Projects
Status: Todo
Development

No branches or pull requests

2 participants