From bc1c20bbf99b028106b9e38591e64b93971f94d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Guimmara?= Date: Tue, 7 Jan 2025 14:33:04 +0100 Subject: [PATCH 1/6] fix(GLTFExtensionsPlugin.d.ts): make all parameters optional --- src/plugins/three/GLTFExtensionsPlugin.d.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/plugins/three/GLTFExtensionsPlugin.d.ts b/src/plugins/three/GLTFExtensionsPlugin.d.ts index b7c64b50c..d2d56ad55 100644 --- a/src/plugins/three/GLTFExtensionsPlugin.d.ts +++ b/src/plugins/three/GLTFExtensionsPlugin.d.ts @@ -5,14 +5,14 @@ import { GLTFLoaderPlugin, GLTFParser } from 'three/examples/jsm/loaders/GLTFLoa export class GLTFExtensionsPlugin { constructor( options: { - metadata: boolean, - rtc: boolean, + metadata?: boolean, + rtc?: boolean, - plugins: Array<( parser: GLTFParser ) => GLTFLoaderPlugin>, + plugins?: Array<( parser: GLTFParser ) => GLTFLoaderPlugin>, - dracoLoader: DRACOLoader | null, - ktxLoader: KTX2Loader | null, - autoDispose: boolean, + dracoLoader?: DRACOLoader | null, + ktxLoader?: KTX2Loader | null, + autoDispose?: boolean, } ); } From a33ed9dffc93ccb4612a2d81c70ed5f0b3fbe1cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Guimmara?= Date: Tue, 7 Jan 2025 14:43:52 +0100 Subject: [PATCH 2/6] fix(TileCompressionPlugin.d.ts): make all parameters optional --- src/plugins/three/TileCompressionPlugin.d.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/plugins/three/TileCompressionPlugin.d.ts b/src/plugins/three/TileCompressionPlugin.d.ts index d565a5440..ee893188a 100644 --- a/src/plugins/three/TileCompressionPlugin.d.ts +++ b/src/plugins/three/TileCompressionPlugin.d.ts @@ -2,17 +2,17 @@ import { TypedArray } from 'three'; export class TileCompressionPlugin { - constructor( options: { - generateNormals: boolean, - disableMipmaps: boolean, - compressIndex: boolean, - compressNormals: boolean, - compressUvs: boolean, - compressPosition: boolean, + constructor( options?: { + generateNormals?: boolean, + disableMipmaps?: boolean, + compressIndex?: boolean, + compressNormals?: boolean, + compressUvs?: boolean, + compressPosition?: boolean, - uvType: TypedArray, - normalType: TypedArray, - positionType: TypedArray, + uvType?: TypedArray, + normalType?: TypedArray, + positionType?: TypedArray, } ); } From f2a370dda382b5075d187939416d00b3760a77a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Guimmara?= Date: Tue, 7 Jan 2025 14:44:10 +0100 Subject: [PATCH 3/6] fix(UnloadTilesPlugin.d.ts): make all parameters optional --- src/plugins/three/UnloadTilesPlugin.d.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/three/UnloadTilesPlugin.d.ts b/src/plugins/three/UnloadTilesPlugin.d.ts index 5d4ec4524..0c871e02e 100644 --- a/src/plugins/three/UnloadTilesPlugin.d.ts +++ b/src/plugins/three/UnloadTilesPlugin.d.ts @@ -1,8 +1,8 @@ export class UnloadTilesPlugin { - constructor( options: { - delay: number, - bytesTarget: number, + constructor( options?: { + delay?: number, + bytesTarget?: number, } ); } From 436568ad0b2f8c63a39f39bb677b69d4b6806300 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Guimmara?= Date: Tue, 7 Jan 2025 14:44:27 +0100 Subject: [PATCH 4/6] fix(TilesFadePlugin.d.ts): make all parameters optional --- src/plugins/three/fade/TilesFadePlugin.d.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/three/fade/TilesFadePlugin.d.ts b/src/plugins/three/fade/TilesFadePlugin.d.ts index 34427d174..dcbd76add 100644 --- a/src/plugins/three/fade/TilesFadePlugin.d.ts +++ b/src/plugins/three/fade/TilesFadePlugin.d.ts @@ -1,9 +1,9 @@ export class TilesFadePlugin { - constructor( options: { - maximumFadeOutTiles: number, - fadeRootTiles: boolean, - fadeDuration: number, + constructor( options?: { + maximumFadeOutTiles?: number, + fadeRootTiles?: boolean, + fadeDuration?: number, } ); } From fa1daa807c6b8747bc156a801be082b0a7f8a941 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Guimmara?= Date: Tue, 7 Jan 2025 14:47:47 +0100 Subject: [PATCH 5/6] fix(ReorientationPlugin.d.ts): make all parameters optional --- src/plugins/three/ReorientationPlugin.d.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/plugins/three/ReorientationPlugin.d.ts b/src/plugins/three/ReorientationPlugin.d.ts index d495de557..295bdc197 100644 --- a/src/plugins/three/ReorientationPlugin.d.ts +++ b/src/plugins/three/ReorientationPlugin.d.ts @@ -1,12 +1,12 @@ export class ReorientationPlugin { - constructor( options: { - up: '+x' | '-x' | '+y' | '-y' | '+z' | '-z', - recenter: boolean, + constructor( options?: { + up?: '+x' | '-x' | '+y' | '-y' | '+z' | '-z', + recenter?: boolean, - lat: number | null, - lon: number | null, - height: number, + lat?: number | null, + lon?: number | null, + height?: number, } ); } From 6b65d025438c16445a42f70527b3d4ba07340fbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Guimmara?= Date: Tue, 7 Jan 2025 14:48:02 +0100 Subject: [PATCH 6/6] fix(GoogleCloudAuthPlugin.d.ts): add missing parameters --- src/plugins/three/GoogleCloudAuthPlugin.d.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/plugins/three/GoogleCloudAuthPlugin.d.ts b/src/plugins/three/GoogleCloudAuthPlugin.d.ts index b117e4a5d..e98ed4fff 100644 --- a/src/plugins/three/GoogleCloudAuthPlugin.d.ts +++ b/src/plugins/three/GoogleCloudAuthPlugin.d.ts @@ -1,5 +1,10 @@ export class GoogleCloudAuthPlugin { - constructor( options : { apiToken: string, autoRefreshToken?: boolean } ); + constructor( options: { + apiToken: string, + autoRefreshToken?: boolean, + logoUrl?: string, + useRecommendedSettings?: boolean; + } ); }