Added remaining color types for PNTS #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
Jul 9, 2023
src/three/PNTSLoader.js
Outdated
| const color = new Color( `rgb(${CONSTANT_RGBA[ 0 ]}, ${CONSTANT_RGBA[ 1 ]}, ${CONSTANT_RGBA[ 2 ]})` ); | ||
| material.color = color; | ||
| material.opacity = CONSTANT_RGBA[ 3 ] / 255; | ||
| material.transparent = true; |
There was a problem hiding this comment.
This should only be set to true if the opacity is < 1.0
src/utilities/rgb565torgb.js
Outdated
Comment on lines
3
to
8
| let r = ( rgb565 & 0xF800 ) >> 11; | ||
| let g = ( rgb565 & 0x07E0 ) >> 5; | ||
| let b = rgb565 & 0x001F; | ||
| r = ( r << 3 ) | ( r >> 2 ); // Scale up red component | ||
| g = ( g << 2 ) | ( g >> 4 ); // Scale up green component | ||
| b = ( b << 3 ) | ( b >> 2 ); // Scale up blue component |
There was a problem hiding this comment.
These all seem like magic numbers. Does this 565 unpacking implementation come from somewhere?
There was a problem hiding this comment.
Hey, I updated the 565 unpacking to a much cleaner one I found over here link, the previous one was taken from a arduino forum.
There was a problem hiding this comment.
Great, thanks! Can we add a comment with a link to that page - then I'll test it and get this merged!
|
Made a few small changes - but this looks great! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for rgba, rgb565 and constant_rgba for PNTSLoader.
The example data used for rgb rgb565 constant_rgba