Fade cleanup (#898)

* Rearrange functions

* clean up

* More cleanup

* rearrangement

* batch tiles plugin rename

* Updates

* comment

* Add display for batched mesh instances

* Fix frustum addition

* Small updates

example/googleMapsExample.js

@@ -349,6 +349,28 @@ function updateHtml() {
 		const programCount = renderer.info.programs.length;
 		str += `Geometries: ${ memory.geometries } Textures: ${ memory.textures } Programs: ${ programCount } Draw Calls: ${ render.calls }`;
 
+		const batchPlugin = tiles.getPluginByName( 'BATCHED_TILES_PLUGIN' );
+		const fadePlugin = tiles.getPluginByName( 'FADE_TILES_PLUGIN' );
+		if ( batchPlugin ) {
+
+			let tot = 0;
+			let totFade = 0;
+			batchPlugin.batchedMesh._instanceInfo.forEach( info => {
+
+				if ( info.visible && info.active ) tot ++;
+
+			} );
+
+			fadePlugin.batchedMesh._instanceInfo.forEach( info => {
+
+				if ( info.visible && info.active ) totFade ++;
+
+			} );
+
+			str += ', Batched: ' + tot + ', Fade Batched: ' + totFade;
+
+		}
+
 	}
 
 	if ( statsContainer.innerHTML !== str ) {

example/src/plugins/batched/BatchedTilesPlugin.js

@@ -30,7 +30,7 @@ export class BatchedTilesPlugin {
 			...options
 		};
 
-		this.name = 'BATCHED_MESH_PLUGIN';
+		this.name = 'BATCHED_TILES_PLUGIN';
 		this.priority = - 1;
 
 		// limit the amount of instances to the size of a 3d texture to avoid over flowing the
@@ -388,4 +388,10 @@ export class BatchedTilesPlugin {
 
 	}
 
+	getTileBatchIds( tile ) {
+
+		return this._tileToInstanceId.get( tile );
+
+	}
+
 }

src/plugins/three/fade/FadeBatchedMesh.js

@@ -2,6 +2,7 @@ import { PassThroughBatchedMesh } from './PassThroughBatchedMesh.js';
 import { RGFormat, UnsignedByteType, DataTexture } from 'three';
 import { wrapFadeMaterial } from './wrapFadeMaterial.js';
 
+// BatchedMesh instance that can fade materials
 export class FadeBatchedMesh extends PassThroughBatchedMesh {
 
 	constructor( ...args ) {
@@ -68,7 +69,11 @@ export class FadeBatchedMesh extends PassThroughBatchedMesh {
 	// dispose the fade texture. Super cannot be used here due to proxy
 	dispose() {
 
-		this.fadeTexture.dispose();
+		if ( this.fadeTexture ) {
+
+			this.fadeTexture.dispose();
+
+		}
 
 	}