Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngProgressHttp gives an error with http requests inside effects #386

Open
TrinTragula opened this issue Dec 3, 2024 · 0 comments · May be fixed by #387
Open

ngProgressHttp gives an error with http requests inside effects #386

TrinTragula opened this issue Dec 3, 2024 · 0 comments · May be fixed by #387

Comments

@TrinTragula
Copy link

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/ngx-progressbar-rqsvic

Steps to reproduce:

  1. Use ngProgressHttp to intercept http requests
  2. Make a request using HttpClient inside of an effect

In the provided StackBlitz:

  1. Let it load
  2. Insert a number in the input form
  3. In the console, you will get the error:
ERROR Error: NG0600: Writing to signals is not allowed in a `computed` or an `effect` by default. Use `allowSignalWrites` in the `CreateEffectOptions` to enable this inside effects.

Expected Behavior

What behavior were you expecting to see?
Everything should work as intended, displaying the progress bar as the request is made

Actual Behavior

What behavior did you actually see?
The application enters an infinite loop

Environment

  • Angular: 18.2
  • ngx-progressbar: 13.0.0
  • Browser(s): Edge, Firefox
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows

I already have a PR ready to fix this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant