[Bug] Pneumatic tube sound plays upon loading

[DarianLStephens]

Minecraft version

1.20.1

CodeChickenLib version

4.6.1.524

CBMultipart version

3.5.0.151

ProjectRed version

4.22.0-beta+14

What happened?

It's very very loud, it would be nice if the tubes didn't do that, and only played the sound when they actually connect. For the first time, not when loaded as well.

Crash log

Not Applicable

How do you make it happen again?

Place pneumatic tubes connected to an inventory and source
Stand next to the tubes
Save and quit
Load the save
Hope that you remembered to turn your volume down

[MrTJP]

Good point. I could see why it happens, since pipes will re-link on world load. I can't reproduce on 1.21.1 though.

A general volume reduction may be in order

[DarianLStephens]

Whoops, I forgot to change the Minecraft version to 1.21.1. That's the version I experienced this on

[DarianLStephens]

Here's a video of the issue in 1.21.1:
https://github.com/user-attachments/assets/5f4de436-9d72-48eb-b3f0-154fad141516

EDIT: Apparently they don't automatically embed, so I'll upload it to YouTube

Here we go:
https://www.youtube.com/watch?v=GvSfjjYfVNg
EDIT 2: Apparently they don't embed here, either. Whatever, it's just me demonstrating the bug with the F3 menu open so you can see the Minecraft version.

[MrTJP]

Hmm. I guess you need a ton of pipes to repro. Doing some sound level reduction now, including a random reduction on top of 0-20% every time it plays. If it's still annoying after that, i'll go into the code and try to do "no sound on world load" logic. Its very messy to detect that, so its last resort.

[DarianLStephens]

Oof.
You can't do something like, only have the sound play if the network is updated via block placement instead of on any connection?

[MrTJP]

Currently they play on "Link added" and "Link removed" events, along with pipe block break. I could perhaps save the link state and try to not fire those events on block re-load if they didn't change. Will have to do that some other time though