Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reshade] add support for scrgb framebuffer #26

Open
startuga opened this issue Dec 27, 2023 · 4 comments
Open

[reshade] add support for scrgb framebuffer #26

startuga opened this issue Dec 27, 2023 · 4 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@startuga
Copy link

The shader works well when the game is in hdr10 but not in scrgb

@MrLixm
Copy link
Owner

MrLixm commented Dec 27, 2023

Hello, do you have any screenshot/documentation link on what you call "scrgb" ?
Why is it not working ?

@MrLixm MrLixm added the bug Something isn't working label Dec 27, 2023
@startuga
Copy link
Author

HDR10PQ disable shaders
FarCry®6 2023-12-28 09ː58ː14

HDR10PQ
FarCry®6 2023-12-28 09ː58ː17

HDR SCRGB
FarCry®6 2023-12-28 10ː04ː34

HDR SCRGB
FarCry®6 2023-12-28 10ː06ː02

Dead Space
HDR
Dead Space 2023-12-28 10ː36ː20
Dead Space 2023-12-28 10ː36ː22

@MrLixm
Copy link
Owner

MrLixm commented Dec 28, 2023

Thanks.
I am surprised the shader works with HDR at all. As of right now there is no option for output colorspace encoding, assuming a "sRGB - Display" (with a 2.2 power function) output.
Also if the same as HDR enabled I don't know what is going on in the reshade side, like what is the encoding of the game visual input ?

Then what is scRGB ? Never heard of it before and looking at Wikipedia it looks like a weird standard with a mention of not being intended for actual display.

With all of that I am not sure I can do much for your request. I don't have an HDR monitor for testing the support of the shader with HDR.

@startuga
Copy link
Author

If you're interested in hdr you can see the work of these two people

https://github.com/EndlesslyFlowering/ReShade_HDR_shaders
https://github.com/Filoppi/PumboAutoHDR/
Thanks.

@MrLixm MrLixm added the wontfix This will not be worked on label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants