Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doclinker sending multiple comments on each label event #12

Open
SD10 opened this issue Apr 1, 2018 · 2 comments
Open

Fix doclinker sending multiple comments on each label event #12

SD10 opened this issue Apr 1, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@SD10
Copy link
Member

SD10 commented Apr 1, 2018

We need to start testing the current peril rules before adding any more. There's a small problem with the doclinker.ts so it's been temporarily disabled. This is blocking re-enabling it

@SD10 SD10 added the enhancement New feature or request label Apr 1, 2018
@SD10
Copy link
Member Author

SD10 commented May 1, 2018

The problem with the doclinker is that it checks if an issue contains the question label and then recommends some documentation.

This is a problem because after the issue is labeled a question, if more labels are added, the doclinker gets re-triggered because the issue still contains the question label.

GitHub also sends one request per label so this leads to a lot of spam.

Reproduce by:

  1. Issue is labeled as question == doclinker triggered
  2. Issue is then labeled as documentation == doclinker triggered
    ...

For these reasons, I don't think there is a way to only trigger an event when a specific label is added.

We would need danger/peril#259

@SD10 SD10 changed the title Unit test peril rules using Jest Fix doclinker sending multiple comments on each label event May 1, 2018
@sunshinejr sunshinejr assigned sunshinejr and unassigned sunshinejr May 1, 2018
@sunshinejr
Copy link
Member

@SD10 do you have some meta-data that could help with identifying actions that were caused by peril maybe? Or can you make an API request without activating webhook? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants