-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing color turns the light off #2
Comments
I have two of these kind of devices and could not reproduce the problem. On both devices, the color was correctly changed to red. Do you have a similar device or even a second one you could test it with as well? |
I recently ran into this issue as well. I purchased a magiclight bulb and an led strip. The led strip works great with your program, however the light bulb will just turn off when attempting to change the color. |
i think i know what is causing the issue the lights aren't rgbw their rgbcw. thank you for your response. |
Cold Warm (cw) is a good hint. I will try to implement this, but I don't have any devices to test. Can you help me and test it when I am ready? |
Yeah can do |
Your program is great, but I have the same issue! |
Remove cold warm (cw) bits from the color command bit mask to hopefully keep the cw devices from being turned off. Related to #2
Thanks for your feedback and sorry for the delay. # Clone this repo
git clone https://github.com/MoonLiightz/magic-home.git
cd magic-home
# Checkout the branch with the fix
git checkout origin/fix/color-change
# Test the fix
go run cmd/main.go color <ip> <r> <g> <b> |
Thanks to you for your efforts !
In the Terminal, the command I successfully use are: Hope this helps!!! |
Thanks @domisol, this helps a lot. |
Hi Patrick. You're welcome. It seems it still doesn't work, but I'm not a github expert, so not sure how to pull the changes you asked me. But for my part I've been wondering a bit more and want to share a few more details with you. |
Thanks for your feedback.
On my device both versions work, how is that for you, can you turn your devices on and off with my program? When I developed this I didn't know about other devices with different commands. Maybe I need to order one of your devices so I can test it myself while programming. I would like to support all of this, including things like presets, but I will have to make a few more changes. Probably even breaking changes so we'll have to go to v2 here. |
Hi guys, as expected, breaking changes are necessary to provide a clean support of cold white devices. I will start the development in the v2 branch and keep you updated. |
discovery and state work fine to turn the light's on and off, but when i try to us the color argument it turns the light off rather than change the color eg: $ magic-home c 192.168.1.7 255 0 0 0
The text was updated successfully, but these errors were encountered: