Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How is this library tested? #18

Open
ZehMatt opened this issue May 31, 2022 · 2 comments
Open

How is this library tested? #18

ZehMatt opened this issue May 31, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@ZehMatt
Copy link

ZehMatt commented May 31, 2022

There are no tests shipped with the source code, are there internal tests and if so wouldn't it be better to ship them as well? High quality code is something that comes with tests. Memory safety is also a huge issue with this library, I wrote a small fuzzer for this library and it doesn't look too good. Considering this is supposed to replace DIA then it should at least have basic bound checks in place since people may load PDBs of untrusted sources.

Its probably best to include in the description that this library is potentially dangerous when PDBs are used from unknown sources.

@tivolo
Copy link

tivolo commented May 31, 2022

Thanks for looking into this.
There are no internal tests (yet), the library is mostly tested by throwing hundreda of PDBs from trusted sources at it.

Would you mind sharing your fuzzer? I'd love to improve the security aspect of the lib.

@ZehMatt
Copy link
Author

ZehMatt commented May 31, 2022

I would recommend libfuzzer or AFL, I just used the example code and provided an entrypoint to be tested.

@MolecularMatters MolecularMatters added the enhancement New feature or request label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants