Skip to content

Commit 2a6fd0c

Browse files
authored
Merge pull request #103 from ModelOriented/cran_sub
CRAN submission
2 parents 14c430b + dfea983 commit 2a6fd0c

7 files changed

+80
-38
lines changed

CRAN-SUBMISSION

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
Version: 0.3.7
2-
Date: 2023-05-17 06:52:31 UTC
3-
SHA: b6e4ce87f93a54e5c451cd06315ab810bb29eb8a
1+
Version: 0.3.8
2+
Date: 2023-09-23 12:06:38 UTC
3+
SHA: 7ca4f7e46e925abd8cf0155227d126ebd9ea2364

DESCRIPTION

+3-4
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,9 @@ Authors@R: c(
77
person("Przemyslaw", "Biecek", , "[email protected]", role = "ctb",
88
comment = c(ORCID = "0000-0001-8423-1823"))
99
)
10-
Description: Efficient implementation of Kernel SHAP, see Lundberg and Lee
11-
(2017) <https://dl.acm.org/doi/10.5555/3295222.3295230>, and Covert
12-
and Lee (2021) <http://proceedings.mlr.press/v130/covert21a>. For
13-
models with up to eight features, the results are exact regarding the
10+
Description: Efficient implementation of Kernel SHAP, see Lundberg and Lee (2017),
11+
and Covert and Lee (2021) <http://proceedings.mlr.press/v130/covert21a>.
12+
For models with up to eight features, the results are exact regarding the
1413
selected background data. Otherwise, an almost exact hybrid algorithm
1514
involving iterative sampling is used. The package plays well together
1615
with meta-learning packages like 'tidymodels', 'caret' or 'mlr3'.

NEWS.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@
77
## Bug fixes
88

99
- {mlr3} probabilistic classification would not work out-of-the-box. This has been fixed (with corresponding example in the README) in https://github.com/ModelOriented/kernelshap/pull/100
10+
- The progress bar was initialized at 1 instead of 0. This is fixed.
1011

1112
## Maintenance
1213

1314
- Added explanation of sampling Kernel SHAP to help file.
14-
- In internal calculations, use explicit `feature_names` as dimnames (https://github.com/ModelOriented/kernelshap/issues/96)
15+
- In internal calculations, use explicit `feature_names` as dimnames (https://github.com/ModelOriented/kernelshap/issues/96).
1516

1617
# kernelshap 0.3.7
1718

R/kernelshap.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ kernelshap.default <- function(object, X, bg_X, pred_fun = stats::predict,
290290
)
291291
} else {
292292
if (verbose && n >= 2L) {
293-
pb <- utils::txtProgressBar(1L, n, style = 3)
293+
pb <- utils::txtProgressBar(max = n, style = 3)
294294
}
295295
res <- vector("list", n)
296296
for (i in seq_len(n)) {

cran-comments.md

+56-14
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,75 @@
1+
# Resubmission II
2+
3+
I have now removed the non-registered DOI from the description file.
4+
5+
This was Uwe's comment:
6+
7+
Found the following (possibly) invalid DOIs:
8+
DOI: 10.5555/3295222.3295230
9+
From: DESCRIPTION
10+
Status: 404
11+
Message: Not Found
12+
13+
and looking for the DOI shows it is not registered.
14+
Even when going to
15+
https://dl.acm.org/doi/10.5555/3295222.3295230
16+
and clicking on the "Publisher Site" link leads us into nirvana.
17+
18+
So I guess the is ill registered and you have to revert the change. My
19+
apologoies, I had not checked whether the DOI given is registreed or not.
20+
21+
Best,
22+
23+
24+
# Resubmission I
25+
26+
I stumbled over a DOI: Uwe gently pointed this out:
27+
28+
"
29+
The Description field contains
30+
<https://dl.acm.org/doi/10.5555/3295222.3295230>, and Covert and Lee
31+
Please use permanent DOI markup for linking to publications as in
32+
<doi:prefix/suffix>.
33+
"
34+
35+
This resubmission fixes this.
36+
37+
# Original message
38+
139
Hello CRAN
240

3-
My recent change introduced Latex errors in help files on MacOS and "oldrel". The reason are "text" instead of "textrm" tags in eqn{} blocks. I will need to fix this in two additional packages, but I will test it with this one.
41+
This is a small maintenance release only.
442

5-
https://cran.r-project.org/web/checks/check_results_kernelshap.html
43+
Thanks a lot
44+
45+
Michael
646

747
## Checks
848

949
### Revdep
1050

11-
survex:
12-
51+
survex 1.1.3
1352
- OK: 1
1453
- BROKEN: 0
1554

16-
### `check(manual = TRUE, cran = TRUE)`
17-
18-
❯ checking for future file timestamps ... NOTE
19-
unable to verify current time
55+
### Local check with innocent NOTE
2056

2157
❯ checking HTML version of manual ... NOTE
2258
Skipping checking HTML validation: no command 'tidy' found
2359

24-
### `check_win_devel()`
25-
26-
OK
60+
### `check_win_devel()` NOTE
2761

28-
### `check_rhub()` Notes
62+
- R Under development (unstable) (2023-09-11 r85126 ucrt)
2963

30-
- kipping checking HTML validation: no command 'tidy' found
31-
- Skipping checking math rendering: package 'V8' unavailable
64+
### `check_rhub()` NOTES
3265

66+
-> Note sure where the 403 problem comes from. Is it relevant?
3367

68+
Found the following (possibly) invalid URLs:
69+
URL: https://dl.acm.org/doi/10.5555/3295222.3295230
70+
From: DESCRIPTION
71+
Status: 403
72+
Message: Forbidden
73+
* checking HTML version of manual ... NOTE
74+
Skipping checking HTML validation: no command 'tidy' found
75+
Skipping checking math rendering: package 'V8' unavailable

packaging.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ use_description(
1717
Title = "Kernel SHAP",
1818
Version = "0.3.8",
1919
Description = "Efficient implementation of Kernel SHAP,
20-
see Lundberg and Lee (2017) <https://dl.acm.org/doi/10.5555/3295222.3295230>,
20+
see Lundberg and Lee (2017),
2121
and Covert and Lee (2021) <http://proceedings.mlr.press/v130/covert21a>.
2222
For models with up to eight features, the results are exact regarding the selected background data.
2323
Otherwise, an almost exact hybrid algorithm involving iterative sampling is used.

revdep/README.md

+14-14
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
# Platform
22

3-
|field |value |
4-
|:--------|:----------------------------------------------------|
5-
|version |R version 4.3.0 (2023-04-21 ucrt) |
6-
|os |Windows 11 x64 (build 22621) |
7-
|system |x86_64, mingw32 |
8-
|ui |RStudio |
9-
|language |(EN) |
10-
|collate |German_Switzerland.utf8 |
11-
|ctype |German_Switzerland.utf8 |
12-
|tz |Europe/Zurich |
13-
|date |2023-05-15 |
14-
|rstudio |2023.03.0+386 Cherry Blossom (desktop) |
15-
|pandoc |2.12 @ C:\Users\Michael\anaconda3\Scripts\pandoc.exe |
3+
|field |value |
4+
|:--------|:--------------------------------------------------------|
5+
|version |R version 4.3.0 (2023-04-21 ucrt) |
6+
|os |Windows 11 x64 (build 22621) |
7+
|system |x86_64, mingw32 |
8+
|ui |RStudio |
9+
|language |(EN) |
10+
|collate |German_Switzerland.utf8 |
11+
|ctype |German_Switzerland.utf8 |
12+
|tz |Europe/Zurich |
13+
|date |2023-09-12 |
14+
|rstudio |2023.06.1+524 Mountain Hydrangea (desktop) |
15+
|pandoc |3.1.6 @ C:\Users\Michael\AppData\Local\Pandoc\pandoc.exe |
1616

1717
# Dependencies
1818

1919
|package |old |new |Δ |
2020
|:----------|:------|:------|:--|
21-
|kernelshap |0.3.6 |0.3.7 |* |
21+
|kernelshap |0.3.7 |0.3.8 |* |
2222
|foreach |1.5.2 |1.5.2 | |
2323
|iterators |1.0.14 |1.0.14 | |
2424

0 commit comments

Comments
 (0)