From 792c4048d7c80d491bef49d8fecee65959df3ca4 Mon Sep 17 00:00:00 2001 From: Michael Mayer Date: Mon, 13 Nov 2023 19:12:21 +0100 Subject: [PATCH 1/2] Move some examples to notrun --- R/ice.R | 2 ++ R/partial_dep.R | 2 ++ cran-comments.md | 26 +++++++++++++------------- man/ice.Rd | 2 ++ man/partial_dep.Rd | 2 ++ 5 files changed, 21 insertions(+), 13 deletions(-) diff --git a/R/ice.R b/R/ice.R index 57f8cc87..92fb2600 100644 --- a/R/ice.R +++ b/R/ice.R @@ -34,6 +34,7 @@ #' plot(ic) #' plot(ic, center = TRUE) #' +#' \dontrun{ #' # Stratified by two variables (the second one goes into facets) #' ic <- ice(fit, v = "Petal.Length", X = iris, BY = c("Petal.Width", "Species")) #' plot(ic) @@ -45,6 +46,7 @@ #' plot(ic) #' plot(ic, center = TRUE) #' plot(ic, swap_dim = TRUE) +#' } #' #' # MODEL 3: Gamma GLM -> pass options to predict() via ... #' fit <- glm(Sepal.Length ~ ., data = iris, family = Gamma(link = log)) diff --git a/R/partial_dep.R b/R/partial_dep.R index 7fea5557..e927a27c 100644 --- a/R/partial_dep.R +++ b/R/partial_dep.R @@ -61,6 +61,7 @@ #' (pd <- partial_dep(fit, v = "Species", X = iris)) #' plot(pd) #' +#' \dontrun{ #' # Stratified by BY variable (numerics are automatically binned) #' pd <- partial_dep(fit, v = "Species", X = iris, BY = "Petal.Length") #' plot(pd) @@ -91,6 +92,7 @@ #' fit, v = c("Petal.Width", "Petal.Length"), X = iris, BY = "Species" #' ) #' pd +#' } #' #' # MODEL 3: Gamma GLM -> pass options to predict() via ... #' fit <- glm(Sepal.Length ~ ., data = iris, family = Gamma(link = log)) diff --git a/cran-comments.md b/cran-comments.md index f4bc2994..4164541b 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,27 +1,27 @@ -# hstats 1.0.0 +# hstats 1.1.0 Dear CRAN team -{hstats} has reached a state that can be called 1.0.0, hurray! +This release mainly brings factor-valued predictions into {hstats}. -THe main improvements are: +## Local checks: 1 NOTE -- Different API improvements. -- Option for fast approximate values. -- Plots now look quite nice. -- Better defaults. - -## Local checks: Harmless note - checking HTML version of manual ... NOTE Skipping checking HTML validation: no command 'tidy' found -## Rhub with typical notes +## Rhub: 3 NOTES * checking HTML version of manual ... NOTE -Skipping checking HTML validation: no command 'tidy' found Skipping checking math rendering: package 'V8' unavailable +* checking for non-standard things in the check directory ... NOTE +Found the following files/directories: + ''NULL'' +* checking for detritus in the temp directory ... NOTE +Found the following files/directories: + 'lastMiKTeXException' ## Winbuilder -Status: OK \ No newline at end of file +Status: OK +R Under development (unstable) (2023-11-12 r85514 ucrt) + diff --git a/man/ice.Rd b/man/ice.Rd index b59330b3..b829d47e 100644 --- a/man/ice.Rd +++ b/man/ice.Rd @@ -149,6 +149,7 @@ ic plot(ic) plot(ic, center = TRUE) +\dontrun{ # Stratified by two variables (the second one goes into facets) ic <- ice(fit, v = "Petal.Length", X = iris, BY = c("Petal.Width", "Species")) plot(ic) @@ -160,6 +161,7 @@ ic <- ice(fit, v = "Petal.Width", X = iris, BY = iris$Species) plot(ic) plot(ic, center = TRUE) plot(ic, swap_dim = TRUE) +} # MODEL 3: Gamma GLM -> pass options to predict() via ... fit <- glm(Sepal.Length ~ ., data = iris, family = Gamma(link = log)) diff --git a/man/partial_dep.Rd b/man/partial_dep.Rd index 96098d0d..d0577a03 100644 --- a/man/partial_dep.Rd +++ b/man/partial_dep.Rd @@ -187,6 +187,7 @@ fit <- lm(Sepal.Length ~ . + Species * Petal.Length, data = iris) (pd <- partial_dep(fit, v = "Species", X = iris)) plot(pd) +\dontrun{ # Stratified by BY variable (numerics are automatically binned) pd <- partial_dep(fit, v = "Species", X = iris, BY = "Petal.Length") plot(pd) @@ -217,6 +218,7 @@ pd <- partial_dep( fit, v = c("Petal.Width", "Petal.Length"), X = iris, BY = "Species" ) pd +} # MODEL 3: Gamma GLM -> pass options to predict() via ... fit <- glm(Sepal.Length ~ ., data = iris, family = Gamma(link = log)) From 8145b4af559b252ca4ee12f2a08213d7367ec3b7 Mon Sep 17 00:00:00 2001 From: Michael Mayer Date: Mon, 13 Nov 2023 20:57:06 +0100 Subject: [PATCH 2/2] Accepted --- CRAN-SUBMISSION | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION index 51dc1846..6fa2b381 100644 --- a/CRAN-SUBMISSION +++ b/CRAN-SUBMISSION @@ -1,3 +1,3 @@ -Version: 1.0.0 -Date: 2023-10-21 15:48:56 UTC -SHA: 81ea6c32524187aefd27b43d3fe9ded32a2a4604 +Version: 1.1.0 +Date: 2023-11-13 18:13:25 UTC +SHA: 792c4048d7c80d491bef49d8fecee65959df3ca4