-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R Objects saved from model_parts() do not find their methods #569
Comments
Would you share |
Thank you so much for the fast response! After loading these packages:
... the After running this code:
... it does.
I compared the two
I loaded those three packages:
... and it fixed the problem! So I am set (and very happy). I have never run into an issue like this with the packages I have built. So, I am very curious to hear what went wrong and how it can be fixed. Do you mind explaining the issue? Again, thank you so much for your wonderful work. You make my job possible. |
Excellent, glad it works. |
Hello DALEX and DALEXtra folks,
My team is incredibly grateful for your work but we have hit a bug (using DALEX 2.4.3 and DALEXtra 2.3.0 under R 4.4.1).
I can use the model_parts() function to make an object and it prints and plots as it should (it looks like a VIP plot from your book):
When I save and reload the object and packages in another/new R session like this:
the classes on the saved object look right:
but when I plot the object with
plot(vip_lasso)
it no longer displays as a VIP plot. Instead it shows this:and when I print it, it shows all the permutation results rather than the average of the repetitions.
I think that means it is not finding the
plot.model_parts
method and theprint.model_parts
methods,If I make any vip plot (even with different data), for example calling variable_importance()
the problematic plot displays properly if I try to plot it again. That is, the original
vip_lasso
object now plots and prints correctly. I checked the loaded packages before and after runningvariable_importance()
and no other libraries have been loaded as a side effect. The only thing that I can see that changes is, a couple functions in DALEX are no longer promises.Can you think of a reason why the plot and print methods for "model_parts" objects are not being used after the packages are loaded but they are available after making a plot?
The data is large, complex and confidential. So making a REPREX is going to be rough but I can do it if you can't suggest a way to fix this.
The text was updated successfully, but these errors were encountered: