Represent structured resources as files instead of folders in Xcode #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current way matches how Xcode bundles structured resources, and we did it this way for BwX mode. But representing these resources as folders has a few downsides: 1. More files can appear in Xcode than are actually referenced as inputs, because Bazel works on the level of files, not directories 2. The work to translate the files to folder paths isn’t free 3. The translation of files to folder paths broke with rules_apple’s recent runfiles support In a future change I’ll remove all of the code around `.isFolder`, since folder-type files can go down the `file_path` path. Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/represent-strucutred-resources-as-files-instead-of-folder-in-Xcode
branch
from
505e670 to
4f5c797
Compare
luispadron
approved these changes
Oct 28, 2024
brentleyjones
deleted the
bj/represent-strucutred-resources-as-files-instead-of-folder-in-Xcode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way matches how Xcode bundles structured resources, and we did it this way for BwX mode. But representing these resources as folders has a few downsides:
In a future change I’ll remove all of the code around
.isFolder, since folder-type files can go down thefile_pathpath.