-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thread checkers to xcscheme.diagnostics
#3096
Merged
brentleyjones
merged 13 commits into
MobileNativeFoundation:main
from
cerisier:user/corentin/main-thread-checker
Oct 28, 2024
Merged
Add thread checkers to xcscheme.diagnostics
#3096
brentleyjones
merged 13 commits into
MobileNativeFoundation:main
from
cerisier:user/corentin/main-thread-checker
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Corentin Kerisit <[email protected]>
Signed-off-by: Corentin Kerisit <[email protected]>
Signed-off-by: Corentin Kerisit <[email protected]>
Signed-off-by: Corentin Kerisit <[email protected]>
Signed-off-by: Corentin Kerisit <[email protected]>
cerisier
force-pushed
the
user/corentin/main-thread-checker
branch
from
October 24, 2024 17:59
fdeb07c
to
ff38973
Compare
tools/generators/xcschemes/src/Generator/CreateCustomSchemeInfos.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Corentin Kerisit <[email protected]>
Signed-off-by: Corentin Kerisit <[email protected]>
Signed-off-by: Corentin Kerisit <[email protected]>
Signed-off-by: Corentin Kerisit <[email protected]>
cerisier
force-pushed
the
user/corentin/main-thread-checker
branch
from
October 28, 2024 19:05
1353bbd
to
fd0f6ff
Compare
brentleyjones
approved these changes
Oct 28, 2024
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Corentin Kerisit <[email protected]>
brentleyjones
approved these changes
Oct 28, 2024
cerisier
changed the title
Add "Main Thread Checker" and "Thread Performance Checker" to xcscheme.diagnostics
Add Thread checkers to xcscheme.diagnostics
Oct 28, 2024
Signed-off-by: Corentin Kerisit <[email protected]>
cerisier
force-pushed
the
user/corentin/main-thread-checker
branch
from
October 28, 2024 19:36
364283b
to
c2d2c60
Compare
Sorry.. Should be good now. |
brentleyjones
approved these changes
Oct 28, 2024
brentleyjones
changed the title
Add Thread checkers to xcscheme.diagnostics
Add thread checkers to Oct 28, 2024
xcscheme.diagnostics
brentleyjones
merged commit Oct 28, 2024
7b985ff
into
MobileNativeFoundation:main
13 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 additional diagnostics to
xcscheme.diagnostics
as configurable in Xcode like below:They are enabled by default for retrocompat but it's also the default in Xcode.
I wasn't sure what naming convention to adopt in this PR because:
.xcscheme
plist are negative flags, vs the other diagnostics flag which are positive flags:disableMainThreadChecker
.disablePerformanceAntipatternChecker
.disablePerformanceAntipatternChecker
flag doesn't match the name of the option in Xcode:Thread Performance Checker
xcscheme.diagnostic
API only has positive flags but does not mentionenable
:address_sanitizer
,thread_sanitizer
.In the end, I chose to start with the
xcscheme.diagnostic
API and follow the convention there:which uses a positive flag upon until the
xcscheme
tool execution:Let me know if you want this done differently ?