Use the same output base for Xcode Build and Index Build #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing! I'll run some tests on this branch today using our repo! |
|
This means that any settings that are different between normal and index builds can cause reanalysis when switching between the two. I'm debugging if there are any changes on the ruleset side that are needed to add with this, as interally we are def running into an issue with that. |
|
|
brentleyjones
force-pushed
the
bj/use-the-same-output-base-for-xcode-build-and-index-build
branch
from
a19961b to
651b15a
Compare
By using `--preemptible` Bazel flag on Index Builds, normal builds will cause them to cancel instead of block for them. This along with Xcode’s default interrupt means that Index Builds are able to use the same output base with minimal impact to normal builds. This change has numerous benefits: - Indexing completes faster since it can reuse any normal builds that have happened, including analysis - Normal builds complete faster because it can leverage the work done by background Index Builds - Quickly open won’t show two source paths anymore for generated files, since there is now only one path - With only one output base, disk usage is drastically cut down - There is one less Bazel server, so memory usage is drastically cut down Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/use-the-same-output-base-for-xcode-build-and-index-build
branch
from
651b15a to
5b4ef48
Compare
brentleyjones
deleted the
bj/use-the-same-output-base-for-xcode-build-and-index-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
--preemptibleBazel flag on Index Builds, normal builds will cause them to cancel instead of block for them. This along with Xcode’s default interrupt means that Index Builds are able to use the same output base with minimal impact to normal builds.This change has numerous benefits: