Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connects to #279. Misc UI updates. #280

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Connects to #279. Misc UI updates. #280

merged 6 commits into from
Jan 11, 2024

Conversation

jimmyzhen
Copy link
Contributor

Key Changes:

Team page

  • Added Mia
  • Updated titles for Terra and Brooke

Project Overview page

  • Fix cut-off HIPPOC assay icon in Figure1C
  • In “Endurance Training in Young Adult Rats” section, added link to the animal protocol at the end of description

Homepage

  • More contrast for open office hour button
  • Video tutorials button to highlight its availability
  • Add "(MoTrPAC)" to intro text
  • Use more contrast colors on y-axis text for heatmap
  • Make the landscape preprint image clickable with link

* More contrast for open office hour button
* Video tutorials button to highlight its availability
* Add "(MoTrPAC)" to intro text
* Use more contrast colors on y-axis text for heatmap
* Make the landscape preprint image clickable with link
@jimmyzhen jimmyzhen linked an issue Jan 11, 2024 that may be closed by this pull request
cteng585
cteng585 previously approved these changes Jan 11, 2024
Copy link
Collaborator

@cteng585 cteng585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a bit of feedback on the UI/UX:

  • When hovering over cells in the heatmap, the cells only change shape if you're hovering over the color of the cells, not the numbers. When I hover over the numbers, the cell shape changes back from rounded to non-rounded
  • The y-axis labels on the heatmap are still a little difficult to see. Do we have any feedback on a version where there's a white background for the labels?
  • Is there a hover-over change that can be implemented for the landscape paper to indicate that it's clickable? e.g. a cursor change, an increase in the shadow, etc.

Other than that, everything looks great. Thanks Jimmy!

@jimmyzhen
Copy link
Contributor Author

@cteng585 Thank you for the comments! I made more minor CSS adjustments to the UIs given your suggestions in bullet points 2 and 3. Regarding the behavior you observed in bullet point 1, I don't have a good solution to that at the moment but will look into it a bit more in the future.

@jimmyzhen jimmyzhen merged commit 1ef81da into dev Jan 11, 2024
3 checks passed
@jimmyzhen jimmyzhen deleted the 279_JZ_Misc_UI_Updates branch January 21, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc UI updates including adding team page update
2 participants