Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Switch default ACL to Deny on the public_ips #664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remibergsma
Copy link
Member

@remibergsma remibergsma commented Mar 29, 2018

This only affects the INPUT chain, so load_balancer and not port_forwards.

It also fixes a bug where the public_ip ACL was not reset at release/associate time. Fixes #674, fixes #676

@remibergsma
Copy link
Member Author

Test run, this will probably break the load_balancer tests

@borisroman borisroman changed the title Switch default ACL to Deny on the public_ips [WIP] Switch default ACL to Deny on the public_ips Apr 5, 2018
@remibergsma
Copy link
Member Author

Loadbalancer test works fine because it sets default_allow on the public IP address.

@remibergsma remibergsma force-pushed the default-deny-as-default-acl-for-public-acl branch 4 times, most recently from bacfed5 to af2c306 Compare April 10, 2018 09:51
@remibergsma remibergsma force-pushed the default-deny-as-default-acl-for-public-acl branch from af2c306 to 9c7f560 Compare April 10, 2018 09:52
@remibergsma remibergsma changed the title [WIP] Switch default ACL to Deny on the public_ips Switch default ACL to Deny on the public_ips Apr 10, 2018
@remibergsma remibergsma changed the title Switch default ACL to Deny on the public_ips [WIP] Switch default ACL to Deny on the public_ips Apr 10, 2018
@remibergsma
Copy link
Member Author

TODO: Needs more work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch public_ip ACL to default_deny Disassociation of public ip will not reset its ACL
1 participant