-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting PopupRenderPosition seems to have no effect? #632
Comments
By the looks it seems you are using the ASP.NET Core version https://miniprofiler.com/dotnet/AspDotNetCore Check the bottom of the ASP.NET Core page, there is well documented how to place the tags to _Layout.cshtml document. |
then I'd suggest that the dotnet / netstandard version of the library shouldn't have this property available, if it can't be applied? eg something like public class MiniProfilerOptions
{
#if !NETSTANDARD
public RenderPosition PopupRenderPosition { get; set; }
#endif
} because otherwise you're going to get a bunch of stupid questions like mine, surely? Also, I specifically skipped out on the attributes because I was hoping for a central source of truth - I have areas in this app, so I have multiple _Layout.cshtml files (thanks for getting back to me on this though) |
@fluffynuts I just tried this in the samples and cannot repro (e.g. the setting works) - are you sure it's not set specifically on the tag helper in the page or something overriding it? |
hm, having a quick look (vscode, not my main machine) I see a lot of |
Welcome! If that doesn't help let's dig deeper :) |
Ok, so I've looked into this again, and even if I take out all the attributes where I set position, and set position as anything other than |
Since the popup is obscuring some of the navigation I have on my site, I do:
but the popup still renders top-right. Indeed, if I set to
RenderPosition.Left
orRenderPosition.BottomLeft
neither of these is observed either. Is there something I'm missing here?The text was updated successfully, but these errors were encountered: