-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Gallery Functionality #10
Conversation
CSS and js look alright, I'll checkout locally later and leave some feedback from there 👍 |
Quick comment before i start a proper review, I think the way you made images use three columns makes the images tiny on mobile. Also the buttons for going to gallery and suggesting things aren't centered, plz do that ;p Now that we have auto PR publishing it'll be a lot easier to check out what uve made! |
Only small thing I'd want to ask about is making it so when you click the gray background outside the image preview, it gets closed. Would that be easy enough to do? |
yeah i can go ahead and do that |
I'll also go ahead and make that close change to the desktop version also |
I sadly think the loading times as it stands right now make the gallery barely usable. I don't think it's possible to easily make rescaled versions of the things so we've two options: make images fit the full screen and blow em all. the. way. up. Like 1 column only kinda deal... and let lazyloading offset that load time. or find some library that can somehow support this on static files, which I don't think is possible, but maybe you know more than me about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a you problem tbh offz |
bro this has been open for over a year 😭 |
I added new files under the directory of gallery and one file titled gallery.html