Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gallery Functionality #10

Closed
wants to merge 7 commits into from
Closed

Conversation

Naatchi
Copy link

@Naatchi Naatchi commented Feb 17, 2021

I added new files under the directory of gallery and one file titled gallery.html

@Boy0000 Boy0000 requested a review from 0ffz February 17, 2021 17:33
@Boy0000 Boy0000 linked an issue Feb 17, 2021 that may be closed by this pull request
@0ffz
Copy link
Member

0ffz commented Feb 18, 2021

CSS and js look alright, I'll checkout locally later and leave some feedback from there 👍

@0ffz
Copy link
Member

0ffz commented Mar 4, 2021

Quick comment before i start a proper review, I think the way you made images use three columns makes the images tiny on mobile.

image

Also the buttons for going to gallery and suggesting things aren't centered, plz do that ;p

Now that we have auto PR publishing it'll be a lot easier to check out what uve made!

@0ffz
Copy link
Member

0ffz commented Jul 17, 2021

Only small thing I'd want to ask about is making it so when you click the gray background outside the image preview, it gets closed. Would that be easy enough to do?

@Naatchi
Copy link
Author

Naatchi commented Jul 17, 2021

Only small thing I'd want to ask about is making it so when you click the gray background outside the image preview, it gets closed. Would that be easy enough to do?

yeah i can go ahead and do that

@Naatchi
Copy link
Author

Naatchi commented Jul 17, 2021

I'll also go ahead and make that close change to the desktop version also

@0ffz
Copy link
Member

0ffz commented Jul 23, 2021

I sadly think the loading times as it stands right now make the gallery barely usable. I don't think it's possible to easily make rescaled versions of the things so we've two options: make images fit the full screen and blow em all. the. way. up. Like 1 column only kinda deal... and let lazyloading offset that load time.

or find some library that can somehow support this on static files, which I don't think is possible, but maybe you know more than me about this?

Copy link
Member

@0ffz 0ffz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only adding review cause Boy requested it and I want the notification to go away

@Naatchi
Copy link
Author

Naatchi commented Oct 11, 2021

Sounds like a you problem tbh offz

@Naatchi
Copy link
Author

Naatchi commented Mar 27, 2022

bro this has been open for over a year 😭

@Naatchi Naatchi closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery page
3 participants