-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal of new Fork/Reporisory/Name #58
Comments
I totally agree with that. I suggest : As you expect, i'm volunteer to be a maintainer/collaborator. For the coding styles, I recommand the following guides : Perhaps we should discuss improvements when the new repo will be created. On my side in a few days I will have to integrate this module on Android. |
I think this is more about getting a community organized repository up and running, other plans should be discussed later. We should liberally make people collaborators to avoid the situation we've had twice in a row now. Also please make sure to properly attribute the two previous authors for the great work they've done! |
Vote for name: Note that android support is already partially baked in, but simply not On Wed, Jan 20, 2016 at 3:42 PM Johann Hofmann [email protected]
|
Hi there. I'm also agree. This is a good module for React Native, but it'd be better if it'd be more active. I'll collaborate too, as far as my knowledge reaches. :) |
|
👍 |
https://github.com/react-native-simple-router/react-native-simple-router has been created, people participating in this conversation have been invited as organization members. Should we fork or create a clone? |
I'd prefer clone, forks are 2nd class citizens on GitHub unfortunately. We should also make sure to get all pull requests and issues/suggestions that have been done on the other repos and backport them to the new one (that's probably gonna be hard) |
I agree with @johannhof. |
@SEthX We can start working on it if you give our team admin permissions to the repo :) |
I think i did that. did i miss something? |
It works! |
https://github.com/react-native-simple-router-community/react-native-simple-router I've renamed the organisation, seems more fitting. |
Great! |
Glad to see simple router! Weird I didn't get a notification when tagged. If you need a contributor, prior to this module, I have been hacking at some others and got a good idea how people build the routers. |
Unfortunately this module has fallen into unmaintainance.
As having a single author seems to be a bad single point of failure, I propose to move this to a new repository altogether, resubmit it to react.parts and NPM.
I propose we should update the description as well to denote that this is community maintained rather than individual maintained.
Naming wise, here is my suggestion:
react-native-universal-router
Votes?
Alternatives?
Also, we should define priorities about what to do in the new repository:
In order of importance, from my point of view:
!!!) Elect maintainers, I volunteer, who else?
The text was updated successfully, but these errors were encountered: