Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal of new Fork/Reporisory/Name #58

Open
davidLeonardi opened this issue Jan 20, 2016 · 15 comments
Open

Proposal of new Fork/Reporisory/Name #58

davidLeonardi opened this issue Jan 20, 2016 · 15 comments

Comments

@davidLeonardi
Copy link

Unfortunately this module has fallen into unmaintainance.
As having a single author seems to be a bad single point of failure, I propose to move this to a new repository altogether, resubmit it to react.parts and NPM.

I propose we should update the description as well to denote that this is community maintained rather than individual maintained.

Naming wise, here is my suggestion:
react-native-universal-router

Votes?
Alternatives?

Also, we should define priorities about what to do in the new repository:

In order of importance, from my point of view:
!!!) Elect maintainers, I volunteer, who else?

  1. Coding styles
  2. Merge all pull requests/solve current issues
  3. Future plans? Android support? Configuration of routes from within a route rather than from config from a parent only?
@charpeni
Copy link

I totally agree with that.

I suggest : react-native-simple-router to clearly see the advantage compared to other.
But I like react-native-universal-router too if we can support Android.

As you expect, i'm volunteer to be a maintainer/collaborator.

For the coding styles, I recommand the following guides :

Perhaps we should discuss improvements when the new repo will be created. On my side in a few days I will have to integrate this module on Android.

@johannhof
Copy link

I think this is more about getting a community organized repository up and running, other plans should be discussed later. react-native-simple-router is a good naming candidate IMO, although universal would also be fine.

We should liberally make people collaborators to avoid the situation we've had twice in a row now.

Also please make sure to properly attribute the two previous authors for the great work they've done!

@davidLeonardi
Copy link
Author

Vote for name:
react-native-simple-router
or
react-native-universal-router

Note that android support is already partially baked in, but simply not
implemented at a view/template level! Should be easy (mark my words.. hehe)

On Wed, Jan 20, 2016 at 3:42 PM Johann Hofmann [email protected]
wrote:

I think this is more about getting a community organized repository up and
running, other plans should be discussed later. react-native-simple-router
is a good naming candidate IMO, although universal would also be fine.

We should liberally make people collaborators to avoid the situation we've
had twice in a row now.

Also please make sure to properly attribute the two previous authors for
the great work they've done!


Reply to this email directly or view it on GitHub
#58 (comment)
.

@jvlobo
Copy link

jvlobo commented Jan 20, 2016

Hi there.

I'm also agree. This is a good module for React Native, but it'd be better if it'd be more active.

I'll collaborate too, as far as my knowledge reaches.

:)

@charpeni
Copy link

react-native-simple-router has my vote.

@johannhof
Copy link

👍

@davidLeonardi
Copy link
Author

https://github.com/react-native-simple-router/react-native-simple-router has been created, people participating in this conversation have been invited as organization members.

Should we fork or create a clone?

@johannhof
Copy link

I'd prefer clone, forks are 2nd class citizens on GitHub unfortunately. We should also make sure to get all pull requests and issues/suggestions that have been done on the other repos and backport them to the new one (that's probably gonna be hard)

@charpeni
Copy link

I agree with @johannhof.

@johannhof
Copy link

@SEthX We can start working on it if you give our team admin permissions to the repo :)

@davidLeonardi
Copy link
Author

I think i did that. did i miss something?

@charpeni
Copy link

It works!

@davidLeonardi
Copy link
Author

https://github.com/react-native-simple-router-community/react-native-simple-router

I've renamed the organisation, seems more fitting.

@jvlobo
Copy link

jvlobo commented Jan 20, 2016

Great!

@ericraio
Copy link

Glad to see simple router! Weird I didn't get a notification when tagged. If you need a contributor, prior to this module, I have been hacking at some others and got a good idea how people build the routers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants