Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect villager trade emulation in Trading Upgrade #3288

Open
lfreew1ndl opened this issue May 5, 2020 · 2 comments · May be fixed by #3706
Open

Incorrect villager trade emulation in Trading Upgrade #3288

lfreew1ndl opened this issue May 5, 2020 · 2 comments · May be fixed by #3706
Labels
bug OC feature is broken
Milestone
OC 1.9.0

Comments

@lfreew1ndl
Copy link

lfreew1ndl commented May 5, 2020 •
edited
Loading

OC: OpenComputers_MC1.7.10_1.7.5.1290_universal
MC: 1.7.10

By default villagers ignore metadata. So u could trade with them by using different items for example:
Charcoal instead of coal,
broken tools,
etc.
Component trading doesn't ignore metadata.
I think its a defect and should be fixed in the next release.
The main reason why it is so important.
image
@payonel payonel self-assigned this May 26, 2020
@lfreew1ndl
Copy link
Author

lfreew1ndl commented Jul 18, 2020 •
edited
Loading

Villagers in Minecraft 1.12.2 do not ignore metadata. They have the only trades with exact items. So it works OK for Minecraft 1.12.2 and above.

@payonel payonel added the cross_mod OC not working with another mod label May 11, 2021
@payonel payonel removed their assignment May 15, 2021
@asiekierka asiekierka added bug OC feature is broken and removed cross_mod OC not working with another mod labels Sep 2, 2022
@asiekierka asiekierka modified the milestones: OC 1.7.7, OC 1.8.0 Sep 2, 2022
@asiekierka
Copy link
Contributor

asiekierka commented Sep 2, 2022 •
edited
Loading

This is not a cross-mod issue - OpenComputers is not emulating the villager trade properly on 1.7.10. (It could also use an accuracy improvement on 1.12.2.)

  • SlotMerchantResult is utilized to perform trades, complete with a fake EntityPlayer. It has a private method to perform the trade.
  • It seems MerchantResultList.canRecipeBeUsed may be sufficient, though.

@asiekierka asiekierka changed the title component trading Incorrect villager trade emulation in Trading Upgrade Sep 2, 2022
@asiekierka asiekierka modified the milestones: OC 1.8.0, OC 1.9.0 May 30, 2023
zeng-github01 added a commit to zeng-github01/OpenComputers that referenced this issue Apr 14, 2024
@zeng-github01
Fix MightyPirates#3288
53f7c55
@zeng-github01 zeng-github01 linked a pull request Apr 14, 2024 that will close this issue
Open
zeng-github01 added a commit to zeng-github01/OpenComputers that referenced this issue Apr 14, 2024
@zeng-github01
Add checkDamage Boolean for li.cil.oc.util.InventoryUtils#haveSameIte…
1f25cea 
…mType Fixes MightyPirates#3288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug OC feature is broken
Projects
None yet
Milestone
OC 1.9.0
3 participants
@asiekierka @payonel @lfreew1ndl