-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update paragraph "using server variables in rewrite rules" #220
base: main
Are you sure you want to change the base?
Conversation
What is described in paragraph "using server variables in rewrite rules" is not correct. The information In the list about http headers is not correct. A dash in the http header is not converted to an underscore. It should be stated that de underscore from the condition input is converted to a dash. When the statement from the text was true, I could handle a HTTP header with an underscore in it.
|
@Cezus You are wrong. This paragraph is talking about incoming requests, while the one you linked is about "responses". |
You are right, that article does not apply in this matter. But the problem I try to address is still valid. The problem is as following: https://stackoverflow.com/questions/52816655/how-can-url-rewrite-match-http-headers-with-underscores |
@John-Hart please review |
@ning51 could you please verify this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph talks about naming convention of server variables, and it is correct. You may consider add the proposed content at the end of the section "Using server variables in rewrite rules" with an example.
@ning51 @John-Hart if this is an improvement, can I S&M. @ning51 can create an issue to track the suggestion. |
What is described in paragraph "using server variables in rewrite rules" is not correct. The information In the list about http headers is not correct. A dash in the http header is not converted to an underscore. It should be stated that de underscore from the condition input is converted to a dash. When the statement from the text was true, I could handle a HTTP header with an underscore in it.