Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort #14

Open
MichaelCurrin opened this issue Oct 17, 2020 · 1 comment
Open

Add isort #14

MichaelCurrin opened this issue Oct 17, 2020 · 1 comment

Comments

@MichaelCurrin
Copy link
Owner

Here in Makefile

TODO: How do not get error on a dir? for now cd. What args?

sort:
	cd twitterlib && isort
@MichaelCurrin
Copy link
Owner Author

MichaelCurrin commented Oct 17, 2020

Note that pylint actually does pick up bad import order.
Can pylintt fix it?

Given pylint does some of the job and ordering is easy to fix by hand, is isort useful locally?
And what about in CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant