Cache snap state in memory #2980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/cache-state
branch
from
19202f3 to
1a95f6b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2980 +/- ##
=======================================
Coverage 94.72% 94.73%
=======================================
Files 497 498 +1
Lines 10826 10859 +33
Branches 1654 1659 +5
=======================================
+ Hits 10255 10287 +32
- Misses 571 572 +1 ☔ View full report in Codecov by Sentry. |
Mrtenz
force-pushed
the
mrtenz/cache-state
branch
from
2c7f8fa to
cd4b9b3
Compare
| expect(pbkdf2Sha512).toHaveBeenCalledTimes(1); | ||
|
|
||
| snapController.destroy(); | ||
| }); | ||
|
|
||
| it('logs an error message if the state fails to persist', async () => { |
There was a problem hiding this comment.
Can we add a test that the persistence is properly mutexed and therefore queued running two parallel update calls or something
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve performance when using state, especially when using the new state methods (#2916), we now cache state in memory, and write updates to disk asynchronously. The first time the state is fetched, it's cached in the Snap's runtime data, which is used in subsequent calls.