Skip to content

Commit

Permalink
chore: Use Node 22 (#253)
Browse files Browse the repository at this point in the history
[As of October 29](https://github.com/nodejs/Release/tree/87462aac66fe3ce1ee1e3f812af83ccef9873782), Node.js 22 is the active `lts` version, and we should start to configure our repositories to use it as the latest supported version. This also updates our minimum supported Node versions for 18 and 20.
  • Loading branch information
rekmarks authored Oct 30, 2024
1 parent 570f6c2 commit 0188a98
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build-lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.x, 22.x]
steps:
- uses: actions/checkout@v4
- name: Install Corepack via Node
Expand All @@ -32,7 +32,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20.x]
node-version: [22.x]
steps:
- uses: actions/checkout@v4
- name: Install Corepack via Node
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20.x]
node-version: [22.x]
steps:
- uses: actions/checkout@v4
- name: Install Corepack via Node
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.x, 22.x]
steps:
- uses: actions/checkout@v4
- name: Install Corepack via Node
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.x, 22.x]
steps:
- uses: actions/checkout@v4
- name: Install Corepack via Node
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
},
"packageManager": "[email protected]",
"engines": {
"node": "^18.18 || >=20"
"node": "^18.20 || ^20.17 || >=22"
},
"publishConfig": {
"access": "public",
Expand Down
6 changes: 3 additions & 3 deletions yarn.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ async function expectPullRequestTemplate(workspace, workspaceName) {

const pullRequestTemplate = await getWorkspaceFile(
workspace,
'.github/PULL_REQUEST_TEMPLATE.md',
'.github/pull_request_template.md',
);

if (!pullRequestTemplate) {
Expand Down Expand Up @@ -253,8 +253,8 @@ module.exports = defineConfig({
workspace.set('repository.type', 'git');
workspace.set('repository.url', `${workspaceRepository}.git`);

// The package must specify a minimum Node.js version of 18.18.
workspace.set('engines.node', '^18.18 || >=20');
// The package must specify the expected minimum Node versions
workspace.set('engines.node', '^18.20 || ^20.17 || >=22');

// The package must provide the location of the CommonJS-compatible
// entrypoint and its matching type declaration file.
Expand Down

0 comments on commit 0188a98

Please sign in to comment.