fix: cp-7.55.0 networks that are enabled within the network manager cannot be removed

[vinnyhoward]

Description

Problem: Networks that are enabled, can be deleted

Solution : Networks that are enabled within the network manager, cannot be removed in the network settings, unless the filter is set to "All Popular Networks" then the user can remove a network of their choice

Changelog

CHANGELOG entry: Fixed a bug where an enabled network would still be enabled even after deleting it in the network settings

Related issues

Fixes: #18945

Manual testing steps

Feature: Network Manger

  Scenario: user enabled a network, for example AVAX
    Then they goto settings and remove AVAX
    Then they go back to home screen to see AVAX still selected

Screenshots/Recordings

~

Before

MetaMask.Bug.Issue.18945.mp4

After

Cannot remove network if enabled

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-09-02.at.15.57.56.mp4

Can remove network if all networks enabled

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-09-02.at.15.59.16.mp4

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 58c51bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b49cc1c1-77ea-428a-bc48-5e205cdaa995

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: adc3da8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1db701a-89c7-49b0-9a7d-234514f09fa1

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[vinnyhoward]

Adding skip sonar cloud because test coverage doesn't seem to be changing when I update the tests. Probably has to do with the component being really old and having nearly zero test coverage? Adding full test coverage to this component isn't part of my scope of work

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 60f1a55
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c8cbfde3-a82e-446b-b451-c0ee61bcaae8

Note

• You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9e6605b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dbdd7ea3-2847-449f-b628-334623fafc14

Note

• You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 84bba10
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/750813b3-0bdf-48aa-8c17-4b3678cb1480

Note

• You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 393a20b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/780a2fc3-a2ec-4e54-8936-79bd7fc7bd4c

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 857679f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2f3e8318-3e1a-4a6d-943c-7faae80ffb15

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate failed

Failed conditions
10.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud