test: jan 29, etc up to date with main merged into chore test if all passes #13249
+2,006
−1,999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s true, to check CI
…code) from NetworkVerificationInfo component
…code that ran when feature flag was off (which was now dead code)
…ture flag, remove code that ran when feature flag was off (which was now dead code)
…ks on feature flag, remove code that ran when feature flag was off (which was now dead code)
…e. Update the test to mock nav, and snapshot expected to be updated too.
…tests. In more detail, after removal of feature flag and corresponding dead code of ff-off, test now runs on ff-on and required update to show content of accordion before asserting, and update snapshot to match new expected rendering.
…t component default style was changed in main
…r multichain and the deadcode behind it. In the case of this component, it didn't directly have multichain code in it but was rendering a component which did (NetworkVerificationInfo)
… feature flag for multichain and the deadcode behind it. It needs this since it uses components than end up using NetworkVerificationInfo which had some code toggled on and off based on the multichain feature flag which is being removed in this PR.
…eature flag was ON. This check on the feature flag was used in some components to render stuff that should render only when the flag was ON.
…ubleshooting during code cleanup
… since all multichain-permission code is ff-on now
… displayed at initial connection by a dapp. Main branch has an updted version of this component, that, at the time of initial connection, pre-selects all networks. This is the change reflected in this updated snapshot.
…ions component. Creating a snapshot on current main with ff-on, matches the expected snapshot when running the test on the feature branch, which has the feature flag and dead code removed. This proves the result in this feature branch is the same currently in prod. Therefore removing the feature flag does not change this component in prod, at least for the state the snapshot captures.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
EtherWizard33
added
the
No QA Needed
|
unused PR, closing |
|
definelty closing this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a branch to try and get sonar metrics to run, and figure out why they run when they run etc
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist