Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add carousel component #13010

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

feat: add carousel component #13010

wants to merge 30 commits into from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Jan 15, 2025

Description

This PR introduces a new carousel component for displaying banners in the wallet view. The implementation includes:

  1. A new reusable Carousel component with TypeScript support
  2. Integration of the carousel in the wallet view to display promotional banners
  3. Banner state persistence through Redux
  4. New banner images and localized content

The main motivation is to provide a better way to showcase important announcements and features to users directly in their wallet view, improving user engagement and communication.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3909

Manual testing steps

  1. Open the MetaMask Mobile app
  2. Navigate to the wallet view
  3. Verify the carousel is displayed at the top of the screen
  4. Swipe left/right to navigate through different banners
  5. Close the app and reopen to verify banner state persistence
  6. Verify proper banner display across different device sizes

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jonybur jonybur added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3fafda1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/32d1a3cf-1163-4ee8-95a7-126f60634df6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jonybur jonybur marked this pull request as ready for review January 29, 2025 17:37
@jonybur jonybur requested a review from a team as a code owner January 29, 2025 17:37
@jonybur jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4943892
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eef2f63c-4045-417d-be19-8858f140dc0a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jonybur jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c6c7e82
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/33017209-65b6-4f9a-9ad8-9b4ff3f59002

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jonybur jonybur requested review from a team as code owners February 3, 2025 14:20
@jonybur jonybur added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7de8989
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/037d097b-94b4-4c3a-bfcc-d6aa92603359

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@hesterbruikman hesterbruikman added the design-review Any feature that needs feedback from the design team label Feb 3, 2025
@jonybur jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 12b1daa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/df564972-365d-4086-9c30-1f384257e388

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jonybur jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 991161c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9c8eaedb-d554-4044-8e42-6d4576ed3558

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jonybur jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 7, 2025
@jonybur jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c2ccfe3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1caf421d-de65-4137-ac1d-b5547fe03685

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jonybur jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-review Any feature that needs feedback from the design team Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants