Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve assets perfs + fix blurred balances and prices #12843

Merged
merged 13 commits into from
Jan 24, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 7, 2025

Description

Related issues

Fixes: #12724

Manual testing steps

  1. Build android project locally
  2. Add your account or create new one
  3. switch btw network ( the perfs should be good )
  4. switch btw popular network and current network on the token list and check the perfs
  5. the list of assets should be displayed quickly

Screenshots/Recordings

Before

After

Screen.Recording.2025-01-06.at.16.18.39.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0517725
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60c941e8-a3af-45f8-9398-feb4210a03ef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb marked this pull request as ready for review January 8, 2025 16:59
@salimtb salimtb requested review from a team as code owners January 8, 2025 16:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 67.98030% with 65 lines in your changes missing coverage. Please review.

Project coverage is 60.60%. Comparing base (8dacf7b) to head (cd8e3c8).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...onents/UI/Tokens/TokenList/TokenListItem/index.tsx 58.58% 23 Missing and 18 partials ⚠️
app/selectors/tokensController.ts 22.22% 5 Missing and 2 partials ⚠️
...nts/UI/Tokens/TokenList/PortfolioBalance/index.tsx 50.00% 2 Missing and 4 partials ⚠️
app/components/UI/Tokens/index.tsx 89.13% 0 Missing and 5 partials ⚠️
...mponents/Views/NetworkSelector/NetworkSelector.tsx 69.23% 4 Missing ⚠️
app/components/hooks/useDebouncedValue.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12843      +/-   ##
==========================================
+ Coverage   60.06%   60.60%   +0.54%     
==========================================
  Files        1900     1912      +12     
  Lines       42513    42723     +210     
  Branches     5612     5744     +132     
==========================================
+ Hits        25536    25893     +357     
+ Misses      15250    15076     -174     
- Partials     1727     1754      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
@salimtb salimtb requested review from a team as code owners January 9, 2025 10:19
@salimtb salimtb force-pushed the fix/improve-network-switch-perf branch from b1d930b to 3787621 Compare January 9, 2025 10:23
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c57cdf8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0f00b991-3abd-4e23-a31b-8809d9a1d702

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 82bb345
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/388406a9-294e-497f-8d4e-32ef3fcbf8a1

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 943dad6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a6b2a44c-52f3-4b86-9639-ee767b0c858c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini previously approved these changes Jan 24, 2025
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6e06d1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8f4c92bd-64ad-408b-8929-6bb6492826e0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 7c6c721
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46f5d198-78b0-4163-b29b-681282283725

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7c6c721
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46f5d198-78b0-4163-b29b-681282283725

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 08f48cd Jan 24, 2025
38 checks passed
@salimtb salimtb deleted the fix/improve-network-switch-perf branch January 24, 2025 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 24, 2025
@sethkfman sethkfman added release-7.39.0 Issue or pull request that will be included in release 7.39.0 and removed release-7.40.0 Issue or pull request that will be included in release 7.40.0 labels Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project