Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: getAnalyticsParams return anonymous props that's not moved to sensitive props #12728

Open
Tracked by #10784
NicolasMassart opened this issue Dec 17, 2024 · 0 comments
Labels
needs-triage Issues that require triage Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform type-bug Something isn't working

Comments

@NicolasMassart
Copy link
Contributor

NicolasMassart commented Dec 17, 2024

Describe the bug

See

active_currency: { value: tokenSymbol || 'N/A', anonymous: true },
number_tokens_requested: {
value: originalApproveAmount || '0',
anonymous: true,
},

Expected behavior

  • Have two events for Approval Started: anon and non-anon
  • Do not have the number_tokens_requested prop in non-anon event props
  • Have the number_tokens_requested prop in anon event sensitive props

Screenshots/Recordings

No response

Steps to reproduce

  • View the tx approval screen
  • check Approval Started event props
  • no anonymous event, only one non anonymous one but it contains number_tokens_requested

Error messages or log output

Detection stage

On main branch

Version

main

Build type

None

Device

any

Operating system

iOS, Android

Additional context

No response

Severity

No response

@NicolasMassart NicolasMassart added the type-bug Something isn't working label Dec 17, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Dec 17, 2024
@NicolasMassart NicolasMassart added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform labels Dec 17, 2024
@NicolasMassart NicolasMassart added the needs-triage Issues that require triage label Dec 17, 2024
@NicolasMassart NicolasMassart changed the title [Bug]: getAnalyticsParams return an anonymous prop that's not moved to sensitive props [Bug]: getAnalyticsParams return anonymous props that's not moved to sensitive props Dec 17, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issues that require triage Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

1 participant