Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABI encoding is out of date #134

Open
alex-miller-0 opened this issue Mar 12, 2021 · 1 comment
Open

ABI encoding is out of date #134

alex-miller-0 opened this issue Mar 12, 2021 · 1 comment
Labels
enhancement
Milestone
signTypedData_v5

Comments

@alex-miller-0
Copy link

alex-miller-0 commented Mar 12, 2021 •
edited
Loading

This library is using ethereumjs-abi, which does not support the newer ABI_V2 spec and has been deprecated as a result: ethereumjs/ethereumjs-abi#86

ABI_V2 changed the way bytes and string params are encoded and I know from personal experience that ethereumjs-abi does not decode newer messages properly. I don't know if the encoding side will work or not, but I would suggest considering a move to ethers if this repo is still in development.
@just-toby just-toby mentioned this issue Apr 1, 2021
Closed
@deanshelton913
Copy link

This is a legit problemo.

@Gudahtt Gudahtt added this to the v4 milestone Jul 20, 2021
@Gudahtt Gudahtt modified the milestones: v4, signTypedData_v5 Sep 9, 2021
@danfinlay danfinlay mentioned this issue Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
signTypedData_v5
Development

No branches or pull requests
3 participants
@deanshelton913 @Gudahtt @alex-miller-0