Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caip multichain api normalized to internal #4964

Merged

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Nov 21, 2024

Explanation

  • Add getInternalScopesObject
  • Export getInternalScopesObject and getSessionScopes

@jiexi
Copy link
Contributor Author

jiexi commented Nov 21, 2024

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "20.0.0-preview-c58e3946",
  "@metamask-previews/address-book-controller": "6.0.1-preview-c58e3946",
  "@metamask-previews/announcement-controller": "7.0.1-preview-c58e3946",
  "@metamask-previews/approval-controller": "7.1.1-preview-c58e3946",
  "@metamask-previews/assets-controllers": "45.0.0-preview-c58e3946",
  "@metamask-previews/base-controller": "7.0.2-preview-c58e3946",
  "@metamask-previews/build-utils": "3.0.1-preview-c58e3946",
  "@metamask-previews/chain-controller": "0.2.0-preview-c58e3946",
  "@metamask-previews/composable-controller": "9.0.1-preview-c58e3946",
  "@metamask-previews/controller-utils": "11.4.3-preview-c58e3946",
  "@metamask-previews/ens-controller": "15.0.0-preview-c58e3946",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-c58e3946",
  "@metamask-previews/gas-fee-controller": "22.0.1-preview-c58e3946",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-c58e3946",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-c58e3946",
  "@metamask-previews/keyring-controller": "19.0.0-preview-c58e3946",
  "@metamask-previews/logging-controller": "6.0.2-preview-c58e3946",
  "@metamask-previews/message-manager": "11.0.1-preview-c58e3946",
  "@metamask-previews/multichain": "1.0.0-preview-c58e3946",
  "@metamask-previews/name-controller": "8.0.1-preview-c58e3946",
  "@metamask-previews/network-controller": "22.0.2-preview-c58e3946",
  "@metamask-previews/notification-controller": "7.0.0-preview-c58e3946",
  "@metamask-previews/notification-services-controller": "0.14.0-preview-c58e3946",
  "@metamask-previews/permission-controller": "11.0.3-preview-c58e3946",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-c58e3946",
  "@metamask-previews/phishing-controller": "12.3.0-preview-c58e3946",
  "@metamask-previews/polling-controller": "12.0.1-preview-c58e3946",
  "@metamask-previews/preferences-controller": "15.0.0-preview-c58e3946",
  "@metamask-previews/profile-sync-controller": "2.0.0-preview-c58e3946",
  "@metamask-previews/queued-request-controller": "7.0.1-preview-c58e3946",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-c58e3946",
  "@metamask-previews/selected-network-controller": "19.0.0-preview-c58e3946",
  "@metamask-previews/signature-controller": "23.0.0-preview-c58e3946",
  "@metamask-previews/transaction-controller": "40.0.0-preview-c58e3946",
  "@metamask-previews/user-operation-controller": "19.0.0-preview-c58e3946"
}

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiexi jiexi marked this pull request as ready for review November 21, 2024 23:46
@jiexi jiexi requested a review from a team as a code owner November 21, 2024 23:46
@jiexi jiexi merged commit 62975b6 into caip-multichain-api Nov 21, 2024
5 checks passed
@jiexi jiexi deleted the jl/caip-multichain-api-normalized-to-internal branch November 21, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants