feat: Add tokenSortConfig to preferences controller #4747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good!
|
sahar-fehri
reviewed
Oct 8, 2024
7 tasks
…MetaMask/core into feat/mmassets_357-add-token-sort-config
github-merge-queue bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 22, 2024
## **Description** Implements Token Sorting on mobile. This is the mobile implementation of the same feature on extension: MetaMask/metamask-extension#27184 Note that this currently includes a patch of the `PreferencesController`. There is a corresponding PR in core to add this to a formal controller release: MetaMask/core#4747 ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-357 ## **Manual testing steps** Go to Portfolio Screen Sort should allow sorting by declining fiat balance by default. Users can then toggle and sort alphabetically or by declining fiat balance. Import button should function the same as the import token link in footer ## **Screenshots/Recordings** https://github.com/user-attachments/assets/f9a9cf52-ef23-4705-a7db-ae5ecdc232f7 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: salimtb <[email protected]>
|
Maybe we wont this one if this gets merged first https://github.com/MetaMask/core/pull/4860/files#diff-40a12640df782cc92dd07efa2b2f120024eb7c5cf1d9431893406ef39132e272 |
|
Closed as change was included in #4860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adds a
tokenSortConfigtoPreferencesControllerto pair with mobile and extension codebases. This config will tell each application which keys tokens are sorted by, which order they are sorted in, and by which sorting callback they should use while being sorted.References
https://consensyssoftware.atlassian.net/browse/MMASSETS-357
https://consensyssoftware.atlassian.net/browse/MMASSETS-356
Changelog