Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] yarn constraints check fails with consistent dependency versions set in manifests #4577

Closed
MajorLift opened this issue Jul 31, 2024 · 1 comment
Closed

[Regression] yarn constraints check fails with consistent dependency versions set in manifests #4577

MajorLift opened this issue Jul 31, 2024 · 1 comment
Assignees
@cryptodev-2s
Labels
bug Something isn't working team-wallet-framework

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Jul 31, 2024 •
edited
Loading

Severity

This affects all core dependency bumps.

Description

The yarn constraints check (specifically the expectConsistentDependenciesAndDevDependencies method) fails even though version ranges are consistent across all manifest files in core repo workspaces.

References

Acceptance Criteria

yarn constraints passes without errors iff. the versions specified for dependencies and devDependencies are consistent across all workspace manifest files.
@MajorLift MajorLift added bug Something isn't working team-wallet-framework labels Jul 31, 2024
@MajorLift MajorLift changed the title yarn constraints regression: expectConsistentDependenciesAndDevDependencies results inconsistent with manifest files yarn constraints regression: expectConsistentDependenciesAndDevDependencies results inconsistent with dependency versions in manifests Aug 1, 2024
@MajorLift MajorLift changed the title yarn constraints regression: expectConsistentDependenciesAndDevDependencies results inconsistent with dependency versions in manifests [regression (yarn constraints)] expectConsistentDependenciesAndDevDependencies results are inconsistent with dependency versions set in manifests Aug 1, 2024
@MajorLift MajorLift changed the title [regression (yarn constraints)] expectConsistentDependenciesAndDevDependencies results are inconsistent with dependency versions set in manifests [Regression] yarn constraints check fails with consistent dependency versions set in manifests Aug 1, 2024
@desi
Copy link
Contributor

desi commented Aug 1, 2024

We missed updating in the PermissionsController. @cryptodev-2s

@MajorLift MajorLift closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptodev-2s cryptodev-2s

Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@desi @MajorLift @cryptodev-2s