Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github validate action doesn't cache node_modules properly #24

Closed
ritave opened this issue Jul 20, 2022 · 1 comment · Fixed by #158
Closed

Github validate action doesn't cache node_modules properly #24

ritave opened this issue Jul 20, 2022 · 1 comment · Fixed by #158
Labels
bug Something isn't working tools This issue concerns the tooling used in this repository

Comments

@ritave
Copy link
Contributor

ritave commented Jul 20, 2022

.github/workflows/validate.yml:validate action fails to recover cache using actions/cache@v2 step.

My theory is that due to changed default directory for all steps inside that job, the actions/cache@v2 step gets confused concerning the path that should be cached and tries to cache a non existing folder.
@ritave ritave added the bug Something isn't working label Jul 20, 2022
@ritave ritave added the tools This issue concerns the tooling used in this repository label Sep 8, 2022
@ajeetd
Copy link

ajeetd commented Feb 11, 2025

@Mrtenz going to close this unless you object

@Mrtenz Mrtenz mentioned this issue Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tools This issue concerns the tooling used in this repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update validation workflow MetaMask/SIPs
2 participants
@ritave @ajeetd