Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASMR will indefinitely wait for a BTC lock, even to the point where if it's published, it's timelock will have expired #11

Open
kayabaNerve opened this issue Nov 30, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@kayabaNerve
Copy link
Member

This is a DoS which arguably doesn't matter as the counterparty never locks their own funds and can simply kill their ASMR instance if this happens. That said, the time to decide to kill, hit Ctrl^C, and kill could theoretically overlap with the BTC actually being sent which would cause ASMR to move forward (assuming it still has a valid timelock).

If ASMR is expanded past the PoC point, this could cause issues. As of right now, even if ASMR moved forward, I believe it'll solely print an address to send the XMR to? So it's not an issue if it's killed because the user who kills won't then send to the address, if it does proceed to that point.

@kayabaNerve kayabaNerve added the bug Something isn't working label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant