Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing and reopening PR makes mergify continually close it #442

Open
howardjohn opened this issue Jun 25, 2019 · 2 comments
Open

Closing and reopening PR makes mergify continually close it #442

howardjohn opened this issue Jun 25, 2019 · 2 comments

Comments

@howardjohn
Copy link

Example: istio/istio#15129
2019-25-06_11-14-42

is this intended behavior? It seems maybe a race condition where it sees it is closed and goes to delete the branch, but by then it is already open

@jd
Copy link
Member

jd commented Jun 25, 2019

There are a few implicit rules on backports, such as deleting the base branch that Mergify has created once the PR is closed.

You closed the PR, so Mergify took action to delete the branch it created, which made GitHub close the PR as you can see in the UI.

There might be a race condition or an event that should have been ignored here as you were fighting with it. I let @sileht comment :)

@howardjohn
Copy link
Author

Thanks for the explanation. I forgot to mention after that image it remains opened which led me to believe there may be some race. Either way not a huge concern since we can just reopen it eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants