Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path based reviews #147

Open
Toflar opened this issue Aug 17, 2018 · 5 comments
Open

Path based reviews #147

Toflar opened this issue Aug 17, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Toflar
Copy link

Toflar commented Aug 17, 2018

Hi, not sure if this is the right place to ask or propose this idea but what would be really great is if you could automatically merge PRs that only affect changed files of a certain path.
The use case would be something like a central repository that is used for meta data such as for example Symfony's recipes contrib repo (https://github.com/symfony/recipes-contrib).
There are loads of recipes for all kinds of different vendors and everybody is allowed to add PRs but you cannot grant 500 people push access but rather just want them to review and approve PRs that affect e.g. their own vendor path.
That's why it would be awesome if you could configure people that are sort of "owner" of a given path so that even though these users do not have push access to the repo, they can trigger mergify by approving the PR.

So something like

path_owners:
   - { path: '/vendor', users: ['foobar', 'other-person'] }
   - { path: '/different-path/sub-directory', users: ['john-doe'] }

Not sure if you understand what I'm talking about 😄

@jd jd added the enhancement New feature or request label Aug 20, 2018
@jd
Copy link
Member

jd commented Aug 20, 2018

This is the right place and an excellent idea.

@sileht sileht self-assigned this Aug 21, 2018
@sileht
Copy link
Member

sileht commented Aug 21, 2018

I think we already support that. In required_pull_request_reviews
section you can set require_code_owner_reviews to true and then create the CODEOWNERS file.

https://doc.mergify.io/configuration.html#required-reviews
https://help.github.com/articles/about-codeowners

Can you check it does what you want ?

@Toflar
Copy link
Author

Toflar commented Aug 24, 2018

I tried it today and unfortunately it does not quite what I need because of this:

The people you choose as code owners must have write permissions for the repository.

Which kind of renders the whole idea useless because I want the mergify bot to merge stuff 😄

@Toflar
Copy link
Author

Toflar commented Feb 11, 2019

Any news here? :)

@howardjohn
Copy link

I think we already support that. In required_pull_request_reviews
section you can set require_code_owner_reviews to true and then create the CODEOWNERS file.

https://doc.mergify.io/configuration.html#required-reviews
https://help.github.com/articles/about-codeowners

Can you check it does what you want ?

This doesn't seem to exist anymore, is this feature still supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants