Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition attribute for unresolved PR comments #1371

Open
melink14 opened this issue Sep 12, 2020 · 4 comments
Open

Add condition attribute for unresolved PR comments #1371

melink14 opened this issue Sep 12, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@melink14
Copy link

My org has a style of leaving final 'nit' comments and approving assuming they'll be fixed before merge but it seems there's no way to tell mergify to not merge if there are open comments.

The alternative would be to create a status check for open comments but it seems round about. :)

Thanks!

@jd
Copy link
Member

jd commented Sep 12, 2020

Hi @melink14!

How do you recognize "open comments"?

@melink14
Copy link
Author

Thanks for the reply.

I mean resolved vs unresolved in github parlance:
image

I was thinking that resolved might be the same as what's referred to by the dismissed-reviews-by but not 100% sure.

@jd
Copy link
Member

jd commented Sep 12, 2020

They are not the same indeed, the dismissed-reviews-by or commented-reviews-by attributes are for the general review of the PR, not about individuals comments.

@jd jd added the enhancement New feature or request label Sep 12, 2020
@melink14
Copy link
Author

GitHub recently released branch protection against unresolved comments so this should work directly for users rely on them (I do).

(Of course, this is only after hours spent on a custom workflow...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants