Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub's preview mergebox ("new merge experience") #29

Closed
MattSturgeon opened this issue Dec 14, 2024 · 4 comments · May be fixed by #32
Closed

Support GitHub's preview mergebox ("new merge experience") #29

MattSturgeon opened this issue Dec 14, 2024 · 4 comments · May be fixed by #32
Assignees

Comments

@MattSturgeon
Copy link

Expected Behavior

The extension to add UI elements to the mergebox

Screenshot with non-preview mergebox

image

Actual Behavior

No UI elements appear

Screenshot with new preview mergebox

image

Steps to Reproduce the Problem

  1. Enable firefox Mergify AddOn
  2. Enable "Try the new merge experience" (can be done with ?new_mergebox=true)
  3. Observe UI elements no longer appear
  4. 😢

Specifications

  • Pull Request URL:
  • Mergify Config URL:
@MattSturgeon
Copy link
Author

MattSturgeon commented Dec 14, 2024

DOM with mergify UI elements

image

DOM for the new preview mergebox

image

@DouglasBlackwood DouglasBlackwood self-assigned this Dec 16, 2024
@DouglasBlackwood
Copy link
Contributor

Hi! It's on our roadmap. I'll keep you updated once it's released.

@DouglasBlackwood
Copy link
Contributor

Hi! We are releasing the browser extension 1.0.14. You should see the action buttons soon.

@MattSturgeon
Copy link
Author

MattSturgeon commented Dec 20, 2024

Hi! We are releasing the browser extension 1.0.14. You should see the action buttons soon.

Hm, I've just updated to 1.0.14 and restarted my browser, but I still can't see the buttons. Debugging the code, I do have the updated tryInject() impl from #30.

Stepping through tryInject(), it seems the issue is that isMergifyEnabledOnTheRepo is null. A breakpoint on line L224 is never hit.

I can confirm that document.querySelector('a[href="/apps/mergify"]') is null when the new mergebox is enabled.

With the new mergebox disabled it exists:
image

The equivalent image in the new mergebox looks like:

<img data-component="Avatar"
     class="flex-shrink-0 ml-2 mr-2 prc-Avatar-Avatar-ZRS-m"
     alt="Summary"
     data-square=""
     width="20"
     height="20"
     style="--avatarSize-regular: 20px;"
     src="https://avatars.githubusercontent.com/in/10562?s=40&amp;v=4"
     data-testid="github-avatar">

But it is not wrapped in an <a> tag:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants