*: SA1019

Author: mreiferson

apps/nsqd/options.go

@@ -43,7 +43,6 @@ var tlsVersionTable = []struct {
 	val uint16
 	str string
 }{
-	{tls.VersionSSL30, "ssl3.0"},
 	{tls.VersionTLS10, "tls1.0"},
 	{tls.VersionTLS11, "tls1.1"},
 	{tls.VersionTLS12, "tls1.2"},

internal/protocol/tcp_server.go

@@ -22,7 +22,9 @@ func TCPServer(listener net.Listener, handler TCPHandler, logf lg.AppLogFunc) er
 	for {
 		clientConn, err := listener.Accept()
 		if err != nil {
-			if nerr, ok := err.(net.Error); ok && nerr.Temporary() {
+			// net.Error.Temporary() is deprecated, but is valid for accept
+			// this is a hack to avoid a staticcheck error
+			if te, ok := err.(interface{ Temporary() bool }); ok && te.Temporary() {
 				logf(lg.WARN, "temporary Accept() failure - %s", err)
 				runtime.Gosched()
 				continue

nsqd/client_v2.go

@@ -376,14 +376,14 @@ func (p *prettyConnectionState) GetCipherSuite() string {
 
 func (p *prettyConnectionState) GetVersion() string {
 	switch p.Version {
-	case tls.VersionSSL30:
-		return "SSL30"
 	case tls.VersionTLS10:
 		return "TLS1.0"
 	case tls.VersionTLS11:
 		return "TLS1.1"
 	case tls.VersionTLS12:
 		return "TLS1.2"
+	case tls.VersionTLS13:
+		return "TLS1.3"
 	default:
 		return fmt.Sprintf("Unknown %d", p.Version)
 	}
@@ -608,6 +608,7 @@ func (c *clientV2) UpgradeSnappy() error {
 	}
 
 	c.Reader = bufio.NewReaderSize(snappy.NewReader(conn), defaultBufferSize)
+	//lint:ignore SA1019 NewWriter is deprecated by NewBufferedWriter, but we're doing our own buffering
 	c.Writer = bufio.NewWriterSize(snappy.NewWriter(conn), c.OutputBufferSize)
 
 	atomic.StoreInt32(&c.Snappy, 1)

nsqd/nsqd.go

@@ -750,8 +750,6 @@ func buildTLSConfig(opts *Options) (*tls.Config, error) {
 		tlsConfig.ClientCAs = tlsCertPool
 	}
 
-	tlsConfig.BuildNameToCertificate()
-
 	return tlsConfig, nil
 }
 

nsqd/protocol_v2_test.go

@@ -1128,6 +1128,7 @@ func TestSnappy(t *testing.T) {
 	test.Equal(t, []byte("OK"), data)
 
 	msgBody := make([]byte, 128000)
+	//lint:ignore SA1019 NewWriter is deprecated by NewBufferedWriter, but we don't want to buffer
 	w := snappy.NewWriter(conn)
 
 	rw := readWriter{compressConn, w}

nsqd/stats_test.go

@@ -93,6 +93,7 @@ func TestClientAttributes(t *testing.T) {
 	test.Equal(t, true, resp.Snappy)
 
 	r := snappy.NewReader(conn)
+	//lint:ignore SA1019 NewWriter is deprecated by NewBufferedWriter, but we don't want to buffer
 	w := snappy.NewWriter(conn)
 	readValidate(t, r, frameTypeResponse, "OK")