We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some functions/variables names can confuse what they really do. For ex., in pkg/utils/utils.go:
pkg/utils/utils.go
35 // HasNetworkAttachment check if pod has Network Attachment 36 func HasNetworkAttachment(pod *kapi.Pod) bool { 37 return len(pod.Annotations[v1.NetworkAttachmentAnnot]) > 0 38 }
function actually check network attachment annotations, not network attachment.
The text was updated successfully, but these errors were encountered:
@adrianchiris
Sorry, something went wrong.
a pod is associated with a network attachment if it has a network attachment annotation. so im not sure there is an issue here.
can you elaborate on why you think there is an issue ?
Originally, You complained that name of this function a bit confusing.
yea well, i dont remember what was confusing :)
So this should be renamed to: HasNetworkAttachmentAnnot()
HasNetworkAttachmentAnnot()
No branches or pull requests
Some functions/variables names can confuse what they really do. For ex., in
pkg/utils/utils.go
:function actually check network attachment annotations, not network attachment.
The text was updated successfully, but these errors were encountered: