Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #1

Open
CST1229 opened this issue Mar 12, 2022 · 1 comment
Open

Suggestions #1

CST1229 opened this issue Mar 12, 2022 · 1 comment
Assignees

Comments

@CST1229
Copy link

CST1229 commented Mar 12, 2022

  1. Don't set the font at all in the share popup. It'll just use Scratch's defaults, so no need to import anything either, and the UI will always be consistent with Scratch. Also, the <font> element is deprecated in HTML.
  2. Don't set overflow: scroll; in the user list in the share popup. It makes ugly scrollbars always appear. Instead, set overflow: auto; to only make scrollbars appear when needed.
  3. Make the profile pictures squares or rounded squares instead of circles, to be consistent with Scratch.
  4. Things called classes, spans, divs and <style></style> tags exist in HTML, you know...
  5. Also, it's a bad idea to have multiple elements with the same ID.
    Yes, I'm too lazy to fork this and make a PR.
@MeechaPooch
Copy link
Owner

These are really awesome helpful suggestions thank you!! Ill implement them tomorrow; heres the discord if you want to join it https://discord.gg/Th8dhGTE

@MeechaPooch MeechaPooch self-assigned this Mar 13, 2022
MeechaPooch added a commit that referenced this issue Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants