Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ code should not pop up message boxes #5

Open
hmeine opened this issue Jan 26, 2016 · 0 comments
Open

C++ code should not pop up message boxes #5

hmeine opened this issue Jan 26, 2016 · 0 comments

Comments

@hmeine
Copy link
Member

hmeine commented Jan 26, 2016

At least two locations try to pop up Windows message boxes as some kind of error handling:

  • Community/General/Sources/ML/MLDicomSurfaceSegmentation/tools/dicom/dicomSSODatasetParser.cpp
  • UMD/METK/Sources/Inventor/UMDSoMeasurement/UMDSoMaximumExtension.cpp

It is probably better to handle errors differently, and not to mix business logic with GUI code. In particular, calling code cannot "see" the errors this way, and end users faced with these messages probably cannot do anything about them. (Developers, on the other hand, should be fine with exceptions and/or log messages.)

Also note the phrase "Windows message boxes". UMDSoMaximumExtension.cpp does compile on other platforms (logging instead), while MLDicomSurfaceSegmentation currently fails due to the missing API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant